Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 856553002: fix defines for openbsd - build fails without them: (Closed)

Created:
5 years, 11 months ago by qbit
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

fix defines for openbsd - build fails without them: Original version from robert@openbsd.org with modification from myself BUG= Committed: https://crrev.com/71fd742fc6f297991bd9fdd1bebc95a75139775c Cr-Commit-Position: refs/heads/master@{#26089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/base/macros.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
qbit
Hi Ben, Here is the change we talked about for the V8_OS_OPENBSD fix. Cheers, Aaron
5 years, 11 months ago (2015-01-15 20:08:24 UTC) #2
noordhuis
On 2015/01/15 20:08:24, qbit wrote: > Hi Ben, > > Here is the change we ...
5 years, 11 months ago (2015-01-15 20:16:35 UTC) #3
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-16 04:39:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856553002/1
5 years, 11 months ago (2015-01-16 04:40:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 05:07:16 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 05:07:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71fd742fc6f297991bd9fdd1bebc95a75139775c
Cr-Commit-Position: refs/heads/master@{#26089}

Powered by Google App Engine
This is Rietveld 408576698