src/ia32/macro-assembler-ia32.cc - Issue 856503002: Massive renaming of PropertyType values and other implied stuff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 856503002: Massive renaming of PropertyType values and other implied stuff. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Spurious file addition fixed Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index a3c235b79648151cce992737bd1a44296ca0b84e..8443c277068d6138344740a851fe3f772c101464 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -1359,7 +1359,7 @@ void MacroAssembler::LoadFromNumberDictionary(Label* miss,

// Check that the value is a field property.

const int kDetailsOffset =

SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize;

- DCHECK_EQ(FIELD, 0);

+ DCHECK_EQ(DATA, 0);

test(FieldOperand(elements, r2, times_pointer_size, kDetailsOffset),

Immediate(PropertyDetails::TypeField::kMask << kSmiTagSize));

j(not_zero, miss);

« no previous file with comments | « src/hydrogen.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »