Massive renaming of PropertyType values and other implied stuff.

test/cctest/test-transitions.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 #include <utility>
 
 #include "src/v8.h"
 
 #include "src/compilation-cache.h"
@@ skipping 23 matching lines @@
                                                   PropertyKind kind,
                                                   PropertyLocation location) {
   int type_value = PropertyDetails::TypeField::encode(type);
   int kind_location_value = PropertyDetails::KindField::encode(kind) |
                             PropertyDetails::LocationField::encode(location);
   CHECK_EQ(type_value, kind_location_value);
 }
 
 
 TEST(PropertyDetailsFieldsConsistency) {
-  CheckPropertyDetailsFieldsConsistency(FIELD, DATA, IN_OBJECT);
-  CheckPropertyDetailsFieldsConsistency(CONSTANT, DATA, IN_DESCRIPTOR);
-  CheckPropertyDetailsFieldsConsistency(ACCESSOR_FIELD, ACCESSOR, IN_OBJECT);
-  CheckPropertyDetailsFieldsConsistency(CALLBACKS, ACCESSOR, IN_DESCRIPTOR);
+  CheckPropertyDetailsFieldsConsistency(DATA, kData, kField);
+  CheckPropertyDetailsFieldsConsistency(DATA_CONSTANT, kData, kDescriptor);
+  CheckPropertyDetailsFieldsConsistency(ACCESSOR, kAccessor, kField);
+  CheckPropertyDetailsFieldsConsistency(ACCESSOR_CONSTANT, kAccessor,
+                                        kDescriptor);
 }
 
 
 TEST(TransitionArray_SimpleFieldTransitions) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
   Isolate* isolate = CcTest::i_isolate();
   Factory* factory = isolate->factory();
 
   Handle<String> name1 = factory->InternalizeUtf8String("foo");
@@ skipping 12 matching lines @@
 
   CHECK(!map0->HasTransitionArray());
   Handle<TransitionArray> transitions = TransitionArray::Allocate(isolate, 0);
   CHECK(transitions->IsFullTransitionArray());
 
   int transition;
   transitions =
       transitions->Insert(map0, name1, map1, SIMPLE_PROPERTY_TRANSITION);
   ConnectTransition(map0, transitions, map1);
   CHECK(transitions->IsSimpleTransition());
-  transition = transitions->Search(DATA, *name1, attributes);
+  transition = transitions->Search(kData, *name1, attributes);
   CHECK_EQ(TransitionArray::kSimpleTransitionIndex, transition);
   CHECK_EQ(*name1, transitions->GetKey(transition));
   CHECK_EQ(*map1, transitions->GetTarget(transition));
 
   transitions =
       transitions->Insert(map0, name2, map2, SIMPLE_PROPERTY_TRANSITION);
   ConnectTransition(map0, transitions, map2);
   CHECK(transitions->IsFullTransitionArray());
 
-  transition = transitions->Search(DATA, *name1, attributes);
+  transition = transitions->Search(kData, *name1, attributes);
   CHECK_EQ(*name1, transitions->GetKey(transition));
   CHECK_EQ(*map1, transitions->GetTarget(transition));
 
-  transition = transitions->Search(DATA, *name2, attributes);
+  transition = transitions->Search(kData, *name2, attributes);
   CHECK_EQ(*name2, transitions->GetKey(transition));
   CHECK_EQ(*map2, transitions->GetTarget(transition));
 
   DCHECK(transitions->IsSortedNoDuplicates());
 }
 
 
 TEST(TransitionArray_FullFieldTransitions) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
@@ skipping 15 matching lines @@
                          OMIT_TRANSITION).ToHandleChecked();
 
   CHECK(!map0->HasTransitionArray());
   Handle<TransitionArray> transitions = TransitionArray::Allocate(isolate, 0);
   CHECK(transitions->IsFullTransitionArray());
 
   int transition;
   transitions = transitions->Insert(map0, name1, map1, PROPERTY_TRANSITION);
   ConnectTransition(map0, transitions, map1);
   CHECK(transitions->IsFullTransitionArray());
-  transition = transitions->Search(DATA, *name1, attributes);
+  transition = transitions->Search(kData, *name1, attributes);
   CHECK_EQ(*name1, transitions->GetKey(transition));
   CHECK_EQ(*map1, transitions->GetTarget(transition));
 
   transitions = transitions->Insert(map0, name2, map2, PROPERTY_TRANSITION);
   ConnectTransition(map0, transitions, map2);
   CHECK(transitions->IsFullTransitionArray());
 
-  transition = transitions->Search(DATA, *name1, attributes);
+  transition = transitions->Search(kData, *name1, attributes);
   CHECK_EQ(*name1, transitions->GetKey(transition));
   CHECK_EQ(*map1, transitions->GetTarget(transition));
 
-  transition = transitions->Search(DATA, *name2, attributes);
+  transition = transitions->Search(kData, *name2, attributes);
   CHECK_EQ(*name2, transitions->GetKey(transition));
   CHECK_EQ(*map2, transitions->GetTarget(transition));
 
   DCHECK(transitions->IsSortedNoDuplicates());
 }
 
 
 TEST(TransitionArray_DifferentFieldNames) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
@@ skipping 19 matching lines @@
                            attributes, Representation::Tagged(),
                            OMIT_TRANSITION).ToHandleChecked();
     names[i] = name;
     maps[i] = map;
 
     transitions = transitions->Insert(map0, name, map, PROPERTY_TRANSITION);
     ConnectTransition(map0, transitions, map);
   }
 
   for (int i = 0; i < PROPS_COUNT; i++) {
-    int transition = transitions->Search(DATA, *names[i], attributes);
+    int transition = transitions->Search(kData, *names[i], attributes);
     CHECK_EQ(*names[i], transitions->GetKey(transition));
     CHECK_EQ(*maps[i], transitions->GetTarget(transition));
   }
 
   DCHECK(transitions->IsSortedNoDuplicates());
 }
 
 
 TEST(TransitionArray_SameFieldNamesDifferentAttributesSimple) {
   CcTest::InitializeVM();
@@ skipping 22 matching lines @@
     attr_maps[i] = map;
 
     transitions = transitions->Insert(map0, name, map, PROPERTY_TRANSITION);
     ConnectTransition(map0, transitions, map);
   }
 
   // Ensure that transitions for |name| field are valid.
   for (int i = 0; i < ATTRS_COUNT; i++) {
     PropertyAttributes attributes = static_cast<PropertyAttributes>(i);
 
-    int transition = transitions->Search(DATA, *name, attributes);
+    int transition = transitions->Search(kData, *name, attributes);
     CHECK_EQ(*name, transitions->GetKey(transition));
     CHECK_EQ(*attr_maps[i], transitions->GetTarget(transition));
   }
 
   DCHECK(transitions->IsSortedNoDuplicates());
 }
 
 
 TEST(TransitionArray_SameFieldNamesDifferentAttributes) {
   CcTest::InitializeVM();
@@ skipping 42 matching lines @@
     attr_maps[i] = map;
 
     transitions = transitions->Insert(map0, name, map, PROPERTY_TRANSITION);
     ConnectTransition(map0, transitions, map);
   }
 
   // Ensure that transitions for |name| field are valid.
   for (int i = 0; i < ATTRS_COUNT; i++) {
     PropertyAttributes attributes = static_cast<PropertyAttributes>(i);
 
-    int transition = transitions->Search(DATA, *name, attributes);
+    int transition = transitions->Search(kData, *name, attributes);
     CHECK_EQ(*name, transitions->GetKey(transition));
     CHECK_EQ(*attr_maps[i], transitions->GetTarget(transition));
   }
 
   // Ensure that info about the other fields still valid.
   for (int i = 0; i < PROPS_COUNT; i++) {
-    int transition = transitions->Search(DATA, *names[i], NONE);
+    int transition = transitions->Search(kData, *names[i], NONE);
     CHECK_EQ(*names[i], transitions->GetKey(transition));
     CHECK_EQ(*maps[i], transitions->GetTarget(transition));
   }
 
   DCHECK(transitions->IsSortedNoDuplicates());
 }