Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 856493002: Oilpan: persist Timer<T>'s object while active. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
CC:
blink-reviews, eae+blinkwatch, fs, eric.carlson_apple.com, kouhei+svg_chromium.org, rwlbuis, krit, arv+blink, blink-reviews-html_chromium.org, danakj, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, pdr+svgwatchlist_chromium.org, nessy, zoltan1, sof, jbroman, timvolodine, Dominik Röttsches, feature-media-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, gyuyoung.kim_webkit.org, Nate Chapin, vcarbune.chromium, philipj_slow, tyoshino+watch_chromium.org, blink-reviews-rendering, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch, mvanouwerkerk+watch_chromium.org, ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: persist Timer<T>'s object while active. To guarantee that when a timer fires and invokes a method on its associated object, keep it alive while the timer is active. R= BUG=420515

Patch Set 1 #

Patch Set 2 : fix mac building #

Patch Set 3 : another blind fix for mac building #

Patch Set 4 : simplified and generalized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -10 lines) Patch
M Source/core/loader/ImageLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Timer.h View 1 2 3 7 chunks +93 lines, -8 lines 0 comments Download
M Source/platform/Timer.cpp View 1 2 3 2 chunks +47 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698