Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Unified Diff: sky/engine/platform/scroll/ScrollableArea.h

Issue 856443005: Delete some noop and dead scrollbar code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/Widget.h ('k') | sky/engine/platform/scroll/ScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/scroll/ScrollableArea.h
diff --git a/sky/engine/platform/scroll/ScrollableArea.h b/sky/engine/platform/scroll/ScrollableArea.h
index 90e493fac8667416b2482607441a0bd191e5c8c7..bc2e26a1556c5497265517fc71c267c9de889ab6 100644
--- a/sky/engine/platform/scroll/ScrollableArea.h
+++ b/sky/engine/platform/scroll/ScrollableArea.h
@@ -65,10 +65,6 @@ public:
void scrollToOffsetWithoutAnimation(const FloatPoint&);
void scrollToOffsetWithoutAnimation(ScrollbarOrientation, float offset);
- // Should be called when the scroll position changes externally, for example if the scroll layer position
- // is updated on the scrolling thread and we need to notify the main thread.
- void notifyScrollPositionChanged(const IntPoint&);
-
static bool scrollBehaviorFromString(const String&, ScrollBehavior&);
bool handleWheelEvent(const PlatformWheelEvent&);
@@ -99,8 +95,6 @@ public:
void contentsResized();
bool hasOverlayScrollbars() const;
- void setScrollbarOverlayStyle(ScrollbarOverlayStyle);
- ScrollbarOverlayStyle scrollbarOverlayStyle() const { return static_cast<ScrollbarOverlayStyle>(m_scrollbarOverlayStyle); }
// This getter will create a ScrollAnimator if it doesn't already exist.
ScrollAnimator* scrollAnimator() const;
@@ -136,9 +130,6 @@ public:
bool shouldSuspendScrollAnimations() const { return true; }
- // NOTE: Only called from Internals for testing.
- void setScrollOffsetFromInternals(const IntPoint&);
-
IntPoint clampScrollPosition(const IntPoint&) const;
// Let subclasses provide a way of asking for and servicing scroll
@@ -190,8 +181,6 @@ private:
unsigned m_verticalScrollElasticity : 2; // ScrollElasticity
unsigned m_horizontalScrollElasticity : 2; // ScrollElasticity
- unsigned m_scrollbarOverlayStyle : 2; // ScrollbarOverlayStyle
-
unsigned m_scrollOriginChanged : 1;
// There are 8 possible combinations of writing mode and direction. Scroll origin will be non-zero in the x or y axis
« no previous file with comments | « sky/engine/platform/Widget.h ('k') | sky/engine/platform/scroll/ScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698