Delete some noop and dead scrollbar code.

sky/engine/platform/scroll/ScrollableArea.cpp

 /*
  * Copyright (c) 2010, Google Inc. All rights reserved.
  * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 56 matching lines @@
 int ScrollableArea::maxOverlapBetweenPages()
 {
     static int maxOverlapBetweenPages = std::numeric_limits<int>::max();
     return maxOverlapBetweenPages;
 }
 
 ScrollableArea::ScrollableArea()
     : m_constrainsScrollingToContentEdge(true)
     , m_verticalScrollElasticity(ScrollElasticityNone)
     , m_horizontalScrollElasticity(ScrollElasticityNone)
-    , m_scrollbarOverlayStyle(ScrollbarOverlayStyleDefault)
     , m_scrollOriginChanged(false)
 {
 }
 
 ScrollableArea::~ScrollableArea()
 {
 }
 
 ScrollAnimator* ScrollableArea::scrollAnimator() const
 {
@@ skipping 55 matching lines @@
 }
 
 void ScrollableArea::scrollToOffsetWithoutAnimation(ScrollbarOrientation orientation, float offset)
 {
     if (orientation == HorizontalScrollbar)
         scrollToOffsetWithoutAnimation(FloatPoint(offset, scrollAnimator()->currentPosition().y()));
     else
         scrollToOffsetWithoutAnimation(FloatPoint(scrollAnimator()->currentPosition().x(), offset));
 }
 
-void ScrollableArea::notifyScrollPositionChanged(const IntPoint& position)
-{
-    scrollPositionChanged(position);
-    scrollAnimator()->setCurrentPosition(position);
-}
-
 void ScrollableArea::scrollPositionChanged(const IntPoint& position)
 {
     TRACE_EVENT0("blink", "ScrollableArea::scrollPositionChanged");
 
     IntPoint oldPosition = scrollPosition();
     // Tell the derived class to scroll its contents.
     setScrollOffset(position);
 
-    Scrollbar* verticalScrollbar = this->verticalScrollbar();
+    if (Scrollbar* scrollbar = this->horizontalScrollbar())
+        scrollbar->offsetDidChange();
 
-    // Tell the scrollbars to update their thumb postions.
-    if (Scrollbar* horizontalScrollbar = this->horizontalScrollbar()) {
-        horizontalScrollbar->offsetDidChange();
-        if (horizontalScrollbar->isOverlayScrollbar()) {
-            if (!verticalScrollbar)
-                horizontalScrollbar->invalidate();
-        }
-    }
-    if (verticalScrollbar) {
-        verticalScrollbar->offsetDidChange();
-        if (verticalScrollbar->isOverlayScrollbar())
-            verticalScrollbar->invalidate();
-    }
+    if (Scrollbar* scrollbar = this->verticalScrollbar())
+        scrollbar->offsetDidChange();
 
     if (scrollPosition() != oldPosition)
         scrollAnimator()->notifyContentAreaScrolled(scrollPosition() - oldPosition);
 }
 
 bool ScrollableArea::scrollBehaviorFromString(const String& behaviorString, ScrollBehavior& behavior)
 {
     if (behaviorString == "auto")
         behavior = ScrollBehaviorAuto;
     else if (behaviorString == "instant")
         behavior = ScrollBehaviorInstant;
     else if (behaviorString == "smooth")
         behavior = ScrollBehaviorSmooth;
     else
         return false;
 
     return true;
 }
 
 bool ScrollableArea::handleWheelEvent(const PlatformWheelEvent& wheelEvent)
 {
     // ctrl+wheel events are used to trigger zooming, not scrolling.
     if (wheelEvent.modifiers() & PlatformEvent::CtrlKey)
         return false;
 
     return scrollAnimator()->handleWheelEvent(wheelEvent);
 }
 
-// NOTE: Only called from Internals for testing.
-void ScrollableArea::setScrollOffsetFromInternals(const IntPoint& offset)
-{
-    setScrollOffsetFromAnimation(offset);
-}
-
 void ScrollableArea::setScrollOffsetFromAnimation(const IntPoint& offset)
 {
     scrollPositionChanged(offset);
 }
 
 void ScrollableArea::mouseEnteredContentArea() const
 {
     if (ScrollAnimator* scrollAnimator = existingScrollAnimator())
         scrollAnimator->mouseEnteredContentArea();
 }
@@ skipping 37 matching lines @@
     if (ScrollAnimator* scrollAnimator = existingScrollAnimator())
         scrollAnimator->finishCurrentScrollAnimations();
 }
 
 void ScrollableArea::didAddScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
 {
     if (orientation == VerticalScrollbar)
         scrollAnimator()->didAddVerticalScrollbar(scrollbar);
     else
         scrollAnimator()->didAddHorizontalScrollbar(scrollbar);
-
-    // <rdar://problem/9797253> AppKit resets the scrollbar's style when you attach a scrollbar
-    setScrollbarOverlayStyle(scrollbarOverlayStyle());
 }
 
 void ScrollableArea::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
 {
     if (orientation == VerticalScrollbar)
         scrollAnimator()->willRemoveVerticalScrollbar(scrollbar);
     else
         scrollAnimator()->willRemoveHorizontalScrollbar(scrollbar);
 }
 
 void ScrollableArea::contentsResized()
 {
     if (ScrollAnimator* scrollAnimator = existingScrollAnimator())
         scrollAnimator->contentsResized();
 }
 
 bool ScrollableArea::hasOverlayScrollbars() const
 {
     Scrollbar* vScrollbar = verticalScrollbar();
     if (vScrollbar && vScrollbar->isOverlayScrollbar())
         return true;
     Scrollbar* hScrollbar = horizontalScrollbar();
     return hScrollbar && hScrollbar->isOverlayScrollbar();
 }
 
-void ScrollableArea::setScrollbarOverlayStyle(ScrollbarOverlayStyle overlayStyle)
-{
-    m_scrollbarOverlayStyle = overlayStyle;
-
-    if (Scrollbar* scrollbar = horizontalScrollbar()) {
-        scrollbar->invalidate();
-    }
-
-    if (Scrollbar* scrollbar = verticalScrollbar()) {
-        scrollbar->invalidate();
-    }
-}
-
 bool ScrollableArea::scheduleAnimation()
 {
     WTF_LOG(ScriptedAnimationController, "ScrollableArea::scheduleAnimation: window = %d",
         hostWindow() ? 1 : 0);
     if (HostWindow* window = hostWindow()) {
         window->scheduleAnimation();
         return true;
     }
     return false;
 }
@@ skipping 18 matching lines @@
 {
     return scrollSize(orientation);
 }
 
 float ScrollableArea::pixelStep(ScrollbarOrientation) const
 {
     return 1;
 }
 
 } // namespace blink