Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: ipc/ipc_message_attachment.h

Issue 856443003: IPC: Introduce MessageAttachment and PlatformFileAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_message_attachment.h
diff --git a/ipc/ipc_message_attachment.h b/ipc/ipc_message_attachment.h
new file mode 100644
index 0000000000000000000000000000000000000000..b3174b2a5d0f34c6604d5b1397819c05e15ed194
--- /dev/null
+++ b/ipc/ipc_message_attachment.h
@@ -0,0 +1,33 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IPC_IPC_MESSAGE_ATTACHMENT_H_
+#define IPC_IPC_MESSAGE_ATTACHMENT_H_
+
+#include "base/memory/ref_counted.h"
+#include "ipc/ipc_export.h"
+
+namespace IPC {
+
+// An auxiliary data sent with |Message|. This can be a platform file descriptor
agl 2015/01/15 03:00:53 // Auxiliary data … ("data" is self-plural.)
Hajime Morrita 2015/01/23 00:29:05 Done.
+// or a mojo |MessagePipe|. |GetType()| returns the type of the subclass.
+class IPC_EXPORT MessageAttachment
+ : public base::RefCounted<MessageAttachment> {
+ public:
+ enum Type {
+ TYPE_PLATFORM_FILE, // The instance is |PlatformFileAttachment|.
+ TYPE_MOJO_MESSAGE_PIPE // The instance is a mojo-based class.
agl 2015/01/15 03:00:53 comma at the end
Hajime Morrita 2015/01/23 00:29:05 Done.
+ };
+
+ MessageAttachment();
agl 2015/01/15 03:00:53 Why have this empty constructor? (Chromium even al
Hajime Morrita 2015/01/23 00:29:05 I was confused with some other chromium-specific r
+ virtual Type GetType() const = 0;
+
+ protected:
+ friend class base::RefCounted<MessageAttachment>;
+ virtual ~MessageAttachment();
+};
+
+} // namespace IPC
+
+#endif // IPC_IPC_MESSAGE_ATTACHMENT_H_
« no previous file with comments | « ipc/ipc.gypi ('k') | ipc/ipc_message_attachment.cc » ('j') | ipc/ipc_message_attachment_set.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698