Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java

Issue 85643002: Transfer date/time value to chooser as double (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@doubledate2
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java b/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java
index c5b42ac872cb6d864669c31df73b7ec4f5b4524b..a45bc5734a2f250701c77f854f17ca96c6b35019 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java
@@ -26,13 +26,8 @@ class DateTimeChooserAndroid {
new InputDialogContainer.InputActionDelegate() {
@Override
- public void replaceDateTime(
- int dialogType,
- int year, int month, int day, int hour, int minute,
- int second, int milli, int week) {
- nativeReplaceDateTime(mNativeDateTimeChooserAndroid,
- dialogType,
- year, month, day, hour, minute, second, milli, week);
+ public void replaceDateTime(double value) {
+ nativeReplaceDateTime(mNativeDateTimeChooserAndroid, value);
}
@Override
@@ -42,28 +37,22 @@ class DateTimeChooserAndroid {
});
}
- private void showDialog(int dialogType, int year, int month, int monthDay,
- int hour, int minute, int second, int milli,
- int week, double min, double max, double step) {
- mInputDialogContainer.showDialog(
- dialogType, year, month, monthDay,
- hour, minute, second, milli, week, min, max, step);
+ private void showDialog(int dialogType, double dialogValue,
+ double min, double max, double step) {
+ mInputDialogContainer.showDialog(dialogType, dialogValue, min, max, step);
}
@CalledByNative
private static DateTimeChooserAndroid createDateTimeChooser(
ContentViewCore contentViewCore,
- long nativeDateTimeChooserAndroid, int dialogType,
- int year, int month, int day,
- int hour, int minute, int second, int milli, int week,
+ long nativeDateTimeChooserAndroid,
+ int dialogType, double dialogValue,
double min, double max, double step) {
DateTimeChooserAndroid chooser =
new DateTimeChooserAndroid(
contentViewCore.getContext(),
nativeDateTimeChooserAndroid);
- chooser.showDialog(
- dialogType, year, month, day, hour, minute, second, milli,
- week, min, max, step);
+ chooser.showDialog(dialogType, dialogValue, min, max, step);
return chooser;
}
@@ -77,10 +66,8 @@ class DateTimeChooserAndroid {
textInputTypeMonth, textInputTypeTime, textInputTypeWeek);
}
- private native void nativeReplaceDateTime(
- long nativeDateTimeChooserAndroid, int dialogType,
- int year, int month, int day, int hour, int minute,
- int second, int milli, int week);
+ private native void nativeReplaceDateTime(long nativeDateTimeChooserAndroid,
+ double dialogValue);
private native void nativeCancelDialog(long nativeDateTimeChooserAndroid);
}

Powered by Google App Engine
This is Rietveld 408576698