Transfer date/time value to chooser as double

content/browser/android/date_time_chooser_android.h

Index: content/browser/android/date_time_chooser_android.h
diff --git a/content/browser/android/date_time_chooser_android.h b/content/browser/android/date_time_chooser_android.h
index a5578e01b86425963cb39cf5c801c7f11551ccd3..85ace29400191c5cf36b14992a50631dbbbb081b 100644
--- a/content/browser/android/date_time_chooser_android.h
+++ b/content/browser/android/date_time_chooser_android.h
@@ -22,33 +22,18 @@ class DateTimeChooserAndroid {
   ~DateTimeChooserAndroid();
 
   // DateTimeChooser implementation:
+  // Shows the dialog. |dialog_value| is the date/time value converted to a
+  // number as defined in HTML. (See blink::InputType::parseToNumber())
   void ShowDialog(ContentViewCore* content,
                   RenderViewHost* host,
-                  int type,
-                  int year,
-                  int month,
-                  int day,
-                  int hour,
-                  int minute,
-                  int second,
-                  int milli,
-                  int week,
+                  int dialog_type,

[jochen (gone - plz use gerrit), 2013/11/27 08:59:04]

why don't you pass in ui::TextInputType?

[keishi, 2013/11/27 10:11:53]

Done.

+                  double dialog_value,

[jochen (gone - plz use gerrit), 2013/11/27 08:59:04]

dialog_value is not very descriptive. what about milliseconds_since_epoch?

[keishi, 2013/11/27 10:11:53]

dialog_value mean different things depending on dialog_type.
For TextInputTypeMonth it will be months since epoch, for TextInputTypeTime it
will be milliseconds since midnight.

The same thing was pointed out in a previous iteration of this patch here:
https://codereview.chromium.org/64913002/#msg3

                   double min,
                   double max,
                   double step);
 
-  // Replaces the current value with the one passed the different fields
-  void ReplaceDateTime(JNIEnv* env,
-                       jobject,
-                       jint dialog_type,
-                       jint year,
-                       jint month,
-                       jint day,
-                       jint hour,
-                       jint minute,
-                       jint second,
-                       jint milli,
-                       jint week);
+  // Replaces the current value
+  void ReplaceDateTime(JNIEnv* env, jobject, jdouble value);
 
   // Closes the dialog without propagating any changes.
   void CancelDialog(JNIEnv* env, jobject);