Transfer date/time value to chooser as double

content/browser/android/date_time_chooser_android.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
 #define CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
 
 #include <string>
 
 #include "base/android/jni_helper.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace content {
 
 class ContentViewCore;
 class RenderViewHost;
 
 // Android implementation for DateTimeChooser dialogs.
 class DateTimeChooserAndroid {
  public:
   DateTimeChooserAndroid();
   ~DateTimeChooserAndroid();
 
   // DateTimeChooser implementation:
   void ShowDialog(ContentViewCore* content,
                   RenderViewHost* host,
-                  int type,
-                  int year,
-                  int month,
-                  int day,
-                  int hour,
-                  int minute,
-                  int second,
-                  int milli,
-                  int week,
+                  int dialog_type,
+                  double current_value,

[Miguel Garcia, 2013/11/26 16:07:08]

keep dialog_value to be consistent with the cc file.
Document the parameters now that they are not self explanatory (value is the
dialog value in millis since epoch except for month... or maybe refer to where
are they declared in WebKit).

[keishi, 2013/11/27 06:58:37]

Done. Added comment.

                   double min,
                   double max,
                   double step);
 
-  // Replaces the current value with the one passed the different fields
-  void ReplaceDateTime(JNIEnv* env,
-                       jobject,
-                       jint dialog_type,
-                       jint year,
-                       jint month,
-                       jint day,
-                       jint hour,
-                       jint minute,
-                       jint second,
-                       jint milli,
-                       jint week);
+  // Replaces the current value
+  void ReplaceDateTime(JNIEnv* env, jobject, jdouble value);
 
   // Closes the dialog without propagating any changes.
   void CancelDialog(JNIEnv* env, jobject);
 
   // Propagates the different types of accepted date/time values to the
   // java side.
   static void InitializeDateInputTypes(
        int text_input_type_date, int text_input_type_date_time,
        int text_input_type_date_time_local, int text_input_type_month,
        int text_input_type_time, int text_input_type_week);
 
  private:
   RenderViewHost* host_;
 
   base::android::ScopedJavaGlobalRef<jobject> j_date_time_chooser_;
 
   DISALLOW_COPY_AND_ASSIGN(DateTimeChooserAndroid);
 };
 
 // Native JNI methods
 bool RegisterDateTimeChooserAndroid(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_