Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 856423003: Don't use -Wl,-z,defs for ubsan builds for now. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use -Wl,-z,defs for ubsan builds for now. ubsan: ../../third_party/freetype2/src/src/base/ftsystem.c:233:error: undefined reference to '__ubsan_handle_type_mismatch' ../../third_party/freetype2/src/src/base/ftsystem.c:233:error: undefined reference to '__ubsan_handle_type_mismatch' ubsan_vptr: ../../content/shell/tools/plugin/PluginObject.cpp:1392:error: undefined reference to '__ubsan_vptr_type_cache' ../../content/shell/tools/plugin/PluginObject.cpp:1392:error: undefined reference to '__ubsan_handle_dynamic_type_cache_miss' ../../content/shell/tools/plugin/PluginTest.cpp:61:error: undefined reference to '__ubsan_vptr_type_cache' ../../content/shell/tools/plugin/PluginTest.cpp:61:error: undefined reference to '__ubsan_handle_dynamic_type_cache_miss' BUG=450555, 371125 TBR=inferno@chromium.org Committed: https://crrev.com/24fd209fd5257d3e3f0a88577dd079b19dcb620b Cr-Commit-Position: refs/heads/master@{#312481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 11 months ago (2015-01-21 21:27:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856423003/1
5 years, 11 months ago (2015-01-21 21:29:11 UTC) #4
inferno
lgtm. thanks!
5 years, 11 months ago (2015-01-21 21:32:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 22:29:41 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 22:31:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24fd209fd5257d3e3f0a88577dd079b19dcb620b
Cr-Commit-Position: refs/heads/master@{#312481}

Powered by Google App Engine
This is Rietveld 408576698