Re-prompt Chrome users to run the SRT when a finch param changes.

chrome/browser/prefs/chrome_pref_service_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/chrome_pref_service_factory.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 199 matching lines @@
     PrefHashFilter::TRACKING_STRATEGY_ATOMIC,
     PrefHashFilter::VALUE_IMPERSONAL
   },
 #endif
   {
     21, prefs::kGoogleServicesUsername,
     PrefHashFilter::ENFORCE_ON_LOAD,
     PrefHashFilter::TRACKING_STRATEGY_ATOMIC,
     PrefHashFilter::VALUE_PERSONAL
   },
+#if defined(OS_WIN)
+  {
+    22,
+    prefs::kSwReporterPromptSeed,

[gab, 2015/01/27 19:53:09]

nit: For consistency with other entries in this list, do not wrap this second
parameter.

I understand why you disagree (i.e. prefer git cl format everywhere), but the
current format makes this list easy to read (every item is formatted the exact
same way and it's easy to find what you're looking for); whereas git cl format
blindly packs parameters which makes some items packed differently than others
based on parameter length in this case...

Nice/consistent/human readable argument packing is not really a thing that a
tool like git cl format can do easily.

I have seen numerous times from Chromium OWNERS (e.g. pkasting) on chromium-dev
that human readability in some cases should be favored over git cl format's
output when both respect the style rules. I think this is such a case.

And for your argument that the next person changing this code and running git cl
format will run in the same thing, true, but by then git cl format may have
changed which would reformat this entire list again anyways. The recommendation
I've thus seen on chromium-dev to avoid that is to stick to the style in a local
file and not generate git cl format churn (i.e. this is the exact reason why we
don't git cl format the entire repo).

+    PrefHashFilter::ENFORCE_ON_LOAD,
+    PrefHashFilter::TRACKING_STRATEGY_ATOMIC,
+    PrefHashFilter::VALUE_IMPERSONAL
+  },
+#endif
   // See note at top, new items added here also need to be added to
   // histograms.xml's TrackedPreference enum.
 };
 
 // One more than the last tracked preferences ID above.
 const size_t kTrackedPrefsReportingIDsCount =
     kTrackedPrefs[arraysize(kTrackedPrefs) - 1].reporting_id + 1;
 
 // Each group enforces a superset of the protection provided by the previous
 // one.
@@ skipping 300 matching lines @@
 
 void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
   ProfilePrefStoreManager::RegisterProfilePrefs(registry);
 }
 
 void RegisterPrefs(PrefRegistrySimple* registry) {
   ProfilePrefStoreManager::RegisterPrefs(registry);
 }
 
 }  // namespace chrome_prefs