Fix for plugin id is showing instead of plugin path in chrome://plugins.

Fix for plugin id is showing instead of plugin path in chrome://plugins.

id was getting passed for path,now extension URL is passed so that it will give info about the plugin location.

Changes done to achieve this.

BUG=450616
Committed: https://crrev.com/d874e71e9b1e49133c2c0880f1a726f7878bd3bf
Cr-Commit-Position: refs/heads/master@{#312646}

[Deepak, 2015-01-21 15:50:18]

deepak.m1@samsung.com changed reviewers:
+ yoz@chromium.org

[Deepak, 2015-01-21 15:50:18]

PTAL

[Lei Zhang, 2015-01-21 21:16:02]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-01-21 21:16:03]

Raymes already fix this bug in r312334

[Deepak, 2015-01-22 02:58:57]

On 2015/01/21 21:16:03, Lei Zhang wrote:
> Raymes already fix this bug in r312334

This is not same as raymes fixed.

raymes fixes only name issue that is not human readable.

My changes are on top of raymes changes.

These changes fixes following:
* Location is not human readable. It is currently plugin ID.
Other issues:
* version is not coming.
* MIME type description is not shown.

so PTAL at these changes .
Thanks

[Lei Zhang, 2015-01-22 03:00:55]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2015-01-22 03:23:40]

https://codereview.chromium.org/856393002/diff/1/chrome/browser/extensions/pl...
File chrome/browser/extensions/plugin_manager.cc (right):

https://codereview.chromium.org/856393002/diff/1/chrome/browser/extensions/pl...
chrome/browser/extensions/plugin_manager.cc:96: info.path = extension->path();
The path is sort of unimportant. We could display the URL of the extension if we
really wanted.

https://codereview.chromium.org/856393002/diff/1/chrome/browser/extensions/pl...
chrome/browser/extensions/plugin_manager.cc:97: info.version =
base::UTF8ToUTF16(extension->GetVersionForDisplay());
Since this is bundled with Chrome, let's not version it (note that there is
currently no version displayed)

https://codereview.chromium.org/856393002/diff/1/chrome/browser/extensions/pl...
chrome/browser/extensions/plugin_manager.cc:112: }
We don't need to have a description (there currently isn't one). This isn't very
nice because it's PDF specific so let's avoid it.

[Deepak, 2015-01-22 04:26:15]

Thanks for review.

I understand. But url is coming like :
chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/

This does not give any info for path, so it appears passing extension->path() is
proper.
extension->path() give proper info for plugin location.

Keeping changes only for path in this patch,
As showing non human readable string in location is not right.
PTAL.

[raymes, 2015-01-22 04:36:18]

But the path which gets displayed doesn't even exist because it's a component
extension. I think we should display the URL

[Deepak, 2015-01-22 04:57:27]

On 2015/01/22 04:36:18, raymes wrote:
> But the path which gets displayed doesn't even exist because it's a component
> extension. I think we should display the URL

ok,changes done.
PTAL

[raymes, 2015-01-22 05:03:06]

lgtm

[Deepak, 2015-01-22 05:22:58]

On 2015/01/22 05:03:06, raymes wrote:
> lgtm

@yoz
PTAL.

[Lei Zhang, 2015-01-22 07:32:48]

lgtm, but please update the CL description.

[Deepak, 2015-01-22 08:12:50]

On 2015/01/22 07:32:48, Lei Zhang wrote:
> lgtm, but please update the CL description.

Thanks @thestig for review.

But I still need @yoz approval, as he is file owner.

[Yoyo Zhou, 2015-01-22 15:16:33]

LGTM

[Lei Zhang, 2015-01-22 17:07:50]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-22 17:08:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/856393002/40001

[commit-bot: I haz the power, 2015-01-22 18:51:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-22 18:52:56]

Patchset 3 (id:??) landed as
https://crrev.com/d874e71e9b1e49133c2c0880f1a726f7878bd3bf
Cr-Commit-Position: refs/heads/master@{#312646}