Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 856353004: Fix references to https://sites.google.com/site/skiadocs/. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
jcgregorio, hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : lua #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M CONTRIBUTING View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M README View 1 chunk +1 line, -1 line 0 comments Download
M docs/quickstart.md View 1 chunk +2 lines, -2 lines 0 comments Download
M make.bat View 1 chunk +1 line, -1 line 0 comments Download
M make.py View 2 chunks +5 lines, -5 lines 0 comments Download
M resources/slides_content2.lua View 1 1 chunk +2 lines, -2 lines 0 comments Download
M site/user/quick/windows.md View 1 chunk +1 line, -1 line 0 comments Download
M skia.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
tfarina
5 years, 10 months ago (2015-01-28 17:01:46 UTC) #1
tfarina
Ping?
5 years, 10 months ago (2015-01-30 14:26:36 UTC) #2
jcgregorio
Added hcm to review these changes.
5 years, 10 months ago (2015-02-02 17:30:24 UTC) #4
hcm
One minor update to lua slide URLs, rest looks good https://codereview.chromium.org/856353004/diff/1/resources/slides_content2.lua File resources/slides_content2.lua (left): https://codereview.chromium.org/856353004/diff/1/resources/slides_content2.lua#oldcode5 ...
5 years, 10 months ago (2015-02-02 20:12:31 UTC) #5
tfarina
https://codereview.chromium.org/856353004/diff/1/resources/slides_content2.lua File resources/slides_content2.lua (left): https://codereview.chromium.org/856353004/diff/1/resources/slides_content2.lua#oldcode5 resources/slides_content2.lua:5: - sites.google.com/site/skiadocs On 2015/02/02 20:12:31, hcm wrote: > Let's ...
5 years, 10 months ago (2015-02-03 02:17:13 UTC) #6
hcm
On 2015/02/03 02:17:13, tfarina wrote: > https://codereview.chromium.org/856353004/diff/1/resources/slides_content2.lua > File resources/slides_content2.lua (left): > > https://codereview.chromium.org/856353004/diff/1/resources/slides_content2.lua#oldcode5 > ...
5 years, 10 months ago (2015-02-03 14:02:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856353004/20001
5 years, 10 months ago (2015-02-03 15:03:29 UTC) #9
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
5 years, 10 months ago (2015-02-03 15:03:33 UTC) #11
tfarina
5 years, 10 months ago (2015-02-03 15:13:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4c93a126889bf71b2eab5a5fa6375d731809dcb8.

Powered by Google App Engine
This is Rietveld 408576698