Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 85633004: MIPS: A performance regression in array literal creation was caused by refactoring. (Closed)

Created:
7 years ago by kilvadyb
Modified:
7 years ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: A performance regression in array literal creation was caused by refactoring. Port r18046 (99c7352) Original commit message: A performance regression in array literal creation was caused by refactoring that eliminated a special fast case for shallow arrays. At the same time the general case got a bit slower. This CL restores most of the performance without coding the special fast case. The virtual dispatching is unnecessary because we know what we want to do at compile time. A flag was added to Runtime::CreateArrayLiteral. The flags delivers information about shallowness but also whether or not allocation mementos should be created. This is useful for crankshafted code. BUG=v8:3008 LOG=Y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years ago (2013-11-25 15:42:12 UTC) #1
kisg
LGTM
7 years ago (2013-11-25 16:58:14 UTC) #2
palfia
7 years ago (2013-11-25 21:19:28 UTC) #3
Committed as r18064.

Powered by Google App Engine
This is Rietveld 408576698