Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 856323003: Revert of Make components_browsertests swarmable and add to main waterfall. (Closed)

Created:
5 years, 11 months ago by jam
Modified:
5 years, 11 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make components_browsertests swarmable and add to main waterfall. (patchset #3 id:40001 of https://codereview.chromium.org/863023003/) Reason for revert: Cause mac build flakiness, see http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/21875/steps/compile/logs/stdio I think the '<(PRODUCT_DIR)/Content Shell.app/', line in the isolate needs to go. Looking closer, we should be launching the components_browsertest binary for the renderer as well. Right now it launches Content Shell for the renderer, which seems odd. Original issue's description: > Make components_browsertests swarmable and add to main waterfall. > > - Makes components_browsertests swarmable. > - Adds components_browsertests to the main waterfall for linux, mac and > win bots. > - Updates the chromium tryserver to run components_browsertests as > swarmable. > > BUG=311270 > > Committed: https://crrev.com/7a3df3b7171fa87f556d22803fdc02a67e975865 > Cr-Commit-Position: refs/heads/master@{#312886} TBR=nyquist@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=311270 Committed: https://crrev.com/27ac8082963904942aaebcbf85620ae6e27ad5c9 Cr-Commit-Position: refs/heads/master@{#312976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -119 lines) Patch
D components/components_browsertests.isolate View 1 chunk +0 lines, -65 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Make components_browsertests swarmable and add to main waterfall.
5 years, 11 months ago (2015-01-24 00:22:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856323003/1
5 years, 11 months ago (2015-01-24 00:24:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 00:26:10 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 00:27:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27ac8082963904942aaebcbf85620ae6e27ad5c9
Cr-Commit-Position: refs/heads/master@{#312976}

Powered by Google App Engine
This is Rietveld 408576698