Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 856323002: Restrict tag-update for version generation to cached git repos. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev, hinoka
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restrict tag-update for version generation to cached git repos. Otherwise it's impossible to compile v8 without internet connection. BUG=chromium:446166 LOG=n NOTRY=true Committed: https://crrev.com/c6641e138bb4a81b47f70e62bb9113c87b590a6f Cr-Commit-Position: refs/heads/master@{#26186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M build/generate_version.py View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Jakob Kummerow
lgtm
5 years, 11 months ago (2015-01-21 10:02:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856323002/1
5 years, 11 months ago (2015-01-21 10:08:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/823)
5 years, 11 months ago (2015-01-21 11:15:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856323002/1
5 years, 11 months ago (2015-01-21 11:17:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/832)
5 years, 11 months ago (2015-01-21 12:07:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856323002/1
5 years, 11 months ago (2015-01-21 12:38:25 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 13:02:31 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:02:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6641e138bb4a81b47f70e62bb9113c87b590a6f
Cr-Commit-Position: refs/heads/master@{#26186}

Powered by Google App Engine
This is Rietveld 408576698