Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: src/harmony-array.js

Issue 856303002: Don't take iterable path in ArrayFrom if items[@@iterator] is null (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/v8natives.js » ('j') | src/v8natives.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/harmony-array.js
diff --git a/src/harmony-array.js b/src/harmony-array.js
index 762f746e56d923f1330ac177fa41403a331c18c8..5a4010ffe3d974bb9fb2806ae2b188a66f74ee83 100644
--- a/src/harmony-array.js
+++ b/src/harmony-array.js
@@ -142,7 +142,7 @@ function ArrayFrom(arrayLike, mapfn, receiver) {
}
}
- var iterable = ToIterable(items);
+ var iterable = GetMethod(items, symbolIterator);
arv (Not doing code reviews) 2015/01/21 15:05:18 We now call items.[[Get]](symbolIterator) twice. T
caitp (gmail) 2015/01/21 17:21:49 hmm, well it's trivial to replace the for...of wit
var k;
var result;
var mappedValue;
« no previous file with comments | « no previous file | src/v8natives.js » ('j') | src/v8natives.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698