Bug fix for the pointer lock string problem

chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/logging.h"  // for NOTREACHED()
 #include "base/mac/bundle_locations.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 240 matching lines @@
   [exitLabel_ setFrameSize:windowFrame.size];
   NSLayoutManager* layoutManager = [exitLabel_ layoutManager];
   NSTextContainer* textContainer = [exitLabel_ textContainer];
   [layoutManager ensureLayoutForTextContainer:textContainer];
   NSRect textFrame = [layoutManager usedRectForTextContainer:textContainer];
 
   textFrame.size.width = ceil(NSWidth(textFrame));
   labelFrame.origin.x += NSWidth(labelFrame) - NSWidth(textFrame);
   labelFrame.size = textFrame.size;
   [exitLabel_ setFrame:labelFrame];
+
+  // Update the title of denyButton_ according to the current bubbleType_
+  NSString* denyButtonText =
+      SysUTF16ToNSString(
+        exclusive_access_bubble::GetDenyButtonTextForType(bubbleType_));

[felt, 2015/01/22 23:46:52]

It looks like this is providing a bubbleType_ on that one builder that isn't
handled by the GetDenyButtonTextForType() switch statement. I don't know why it
won't reproduce locally, but my suggestion would be to add some debugging text
to print out the value of bubbleType_ and then run the one bot that's giving you
trouble. That will hopefully let you see what this extra value is and why it
isn't being handled in GetDenyButtonTextForType().

[Jialiu Lin, 2015/01/23 22:55:47]

Done.

+  [denyButton_ setTitle: denyButtonText];
 }
 
 - (NSString*)getLabelText {
   if (bubbleType_ == EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE)
     return @"";
   extensions::ExtensionRegistry* registry =
       extensions::ExtensionRegistry::Get(browser_->profile());
   return SysUTF16ToNSString(exclusive_access_bubble::GetLabelTextForType(
       bubbleType_, url_, registry));
 }
@@ skipping 52 matching lines @@
 - (void)hideSoon {
   hideTimer_.reset(
       [[NSTimer scheduledTimerWithTimeInterval:kInitialDelay
                                         target:self
                                       selector:@selector(hideTimerFired:)
                                       userInfo:nil
                                        repeats:NO] retain]);
 }
 
 @end