Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 85623006: Don't ignore Accept: header for cache/XHR dedupe purposes (Closed)

Created:
7 years ago by Deprecated (see juliatuttle)
Modified:
7 years ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't ignore Accept: header for cache/XHR dedupe purposes See http://crbug.com/315939; varying the Accept header can vary the response we get, so we shouldn't dedupe/cache based on it. BUG=chromium:315939 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162639

Patch Set 1 #

Patch Set 2 : Add RawResourceTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/RawResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A + Source/core/fetch/RawResourceTest.cpp View 1 1 chunk +24 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Deprecated (see juliatuttle)
PTAL, japhet.
7 years ago (2013-11-25 18:43:57 UTC) #1
Nate Chapin
On 2013/11/25 18:43:57, ttuttle wrote: > PTAL, japhet. Code change seems reasonable, any hope of ...
7 years ago (2013-11-25 18:48:51 UTC) #2
Nate Chapin
LGTM, thanks!
7 years ago (2013-11-25 20:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/85623006/20001
7 years ago (2013-11-25 20:20:52 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-25 22:06:28 UTC) #5
Message was sent while issue was closed.
Change committed as 162639

Powered by Google App Engine
This is Rietveld 408576698