Device Orientation API on Chrome OS

content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/device_sensors/data_fetcher_shared_memory.h"
+
+#include "content/browser/device_sensors/sensor_manager_chromeos.h"
+
+namespace content {
+
+DataFetcherSharedMemory::DataFetcherSharedMemory() {
+}
+
+DataFetcherSharedMemory::~DataFetcherSharedMemory() {
+}
+
+bool DataFetcherSharedMemory::Start(ConsumerType consumer_type, void* buffer) {
+  DCHECK(buffer);
+  if (!sensor_manager_.get())

[timvolodine, 2015/01/21 13:16:57]

nit: think you can drop ".get" which results in shorter statement

[jonross, 2015/01/21 16:02:10]

Done.

+    sensor_manager_.reset(new SensorManagerChromeOS);
+
+  switch (consumer_type) {
+    case CONSUMER_TYPE_MOTION:

[timvolodine, 2015/01/21 13:16:57]

is there a todo needed here? any relevant crbug?

[jonross, 2015/01/21 16:02:10]

Added a TODO with relevant CR bug

+      return false;
+    case CONSUMER_TYPE_ORIENTATION:
+      return sensor_manager_->StartFetchingDeviceOrientationData(
+          static_cast<DeviceOrientationHardwareBuffer*>(buffer));
+    case CONSUMER_TYPE_LIGHT:
+      return false;
+    default:
+      NOTREACHED();
+  }
+  return false;
+}
+
+bool DataFetcherSharedMemory::Stop(ConsumerType consumer_type) {
+  bool stopped = false;
+  switch (consumer_type) {
+    case CONSUMER_TYPE_MOTION:
+      break;
+    case CONSUMER_TYPE_ORIENTATION:
+      stopped = sensor_manager_->StopFetchingDeviceOrientationData();
+      break;
+    case CONSUMER_TYPE_LIGHT:
+      break;
+    default:
+      NOTREACHED();
+  }
+  if (!sensor_manager_->IsFetching())
+    sensor_manager_.reset();
+  return stopped;
+}
+
+}  // namespace content