Revert "Revert "delete old things!""

gm/rebaseline_server/static/constants.js

Index: gm/rebaseline_server/static/constants.js
diff --git a/gm/rebaseline_server/static/constants.js b/gm/rebaseline_server/static/constants.js
deleted file mode 100644
index a9601ece719dc95c4074662398a13de4ef7fc142..0000000000000000000000000000000000000000
--- a/gm/rebaseline_server/static/constants.js
+++ /dev/null
@@ -1,100 +0,0 @@
-/*
- * Constants used by our imagediff-viewing Javascript code.
- */
-var module = angular.module(
-    'ConstantsModule',
-    []
-);
-
-module.constant('constants', (function() {
-  return {
-    // NOTE: Keep these in sync with ../column.py
-    KEY__EXTRACOLUMNHEADERS__HEADER_TEXT: 'headerText',
-    KEY__EXTRACOLUMNHEADERS__HEADER_URL: 'headerUrl',
-    KEY__EXTRACOLUMNHEADERS__IS_FILTERABLE: 'isFilterable',
-    KEY__EXTRACOLUMNHEADERS__IS_SORTABLE: 'isSortable',
-    KEY__EXTRACOLUMNHEADERS__USE_FREEFORM_FILTER: 'useFreeformFilter',
-    KEY__EXTRACOLUMNHEADERS__VALUES_AND_COUNTS: 'valuesAndCounts',
-
-    // NOTE: Keep these in sync with ../imagediffdb.py
-    KEY__DIFFERENCES__MAX_DIFF_PER_CHANNEL: 'maxDiffPerChannel',
-    KEY__DIFFERENCES__NUM_DIFF_PIXELS: 'numDifferingPixels',
-    KEY__DIFFERENCES__PERCENT_DIFF_PIXELS: 'percentDifferingPixels',
-    KEY__DIFFERENCES__PERCEPTUAL_DIFF: 'perceptualDifference',
-    KEY__DIFFERENCES__DIFF_URL: 'diffUrl',
-    KEY__DIFFERENCES__WHITE_DIFF_URL: 'whiteDiffUrl',
-
-    // NOTE: Keep these in sync with ../imagepair.py
-    KEY__IMAGEPAIRS__DIFFERENCES: 'differenceData',
-    KEY__IMAGEPAIRS__EXPECTATIONS: 'expectations',
-    KEY__IMAGEPAIRS__EXTRACOLUMNS: 'extraColumns',
-    KEY__IMAGEPAIRS__IMAGE_A_URL: 'imageAUrl',
-    KEY__IMAGEPAIRS__IMAGE_B_URL: 'imageBUrl',
-    KEY__IMAGEPAIRS__IS_DIFFERENT: 'isDifferent',
-    KEY__IMAGEPAIRS__SOURCE_JSON_FILE: 'sourceJsonFile',
-
-    // NOTE: Keep these in sync with ../imagepairset.py
-    KEY__ROOT__EXTRACOLUMNHEADERS: 'extraColumnHeaders',
-    KEY__ROOT__EXTRACOLUMNORDER: 'extraColumnOrder',
-    KEY__ROOT__HEADER: 'header',
-    KEY__ROOT__IMAGEPAIRS: 'imagePairs',
-    KEY__ROOT__IMAGESETS: 'imageSets',
-    //
-    KEY__IMAGESETS__FIELD__BASE_URL: 'baseUrl',
-    KEY__IMAGESETS__FIELD__DESCRIPTION: 'description',
-    KEY__IMAGESETS__SET__DIFFS: 'diffs',
-    KEY__IMAGESETS__SET__IMAGE_A: 'imageA',
-    KEY__IMAGESETS__SET__IMAGE_B: 'imageB',
-    KEY__IMAGESETS__SET__WHITEDIFFS: 'whiteDiffs',
-
-    // NOTE: Keep these in sync with ../results.py
-    KEY__EXPECTATIONS__BUGS: 'bugs',
-    KEY__EXPECTATIONS__IGNOREFAILURE: 'ignore-failure',
-    KEY__EXPECTATIONS__REVIEWED: 'reviewed-by-human',
-    //
-    KEY__EXTRACOLUMNS__BUILDER: 'builder',
-    KEY__EXTRACOLUMNS__CONFIG: 'config',
-    KEY__EXTRACOLUMNS__RESULT_TYPE: 'resultType',
-    KEY__EXTRACOLUMNS__TEST: 'test',
-    //
-    KEY__HEADER__DATAHASH: 'dataHash',
-    KEY__HEADER__IS_EDITABLE: 'isEditable',
-    KEY__HEADER__IS_EXPORTED: 'isExported',
-    KEY__HEADER__IS_STILL_LOADING: 'resultsStillLoading',
-    KEY__HEADER__RESULTS_ALL: 'all',
-    KEY__HEADER__RESULTS_FAILURES: 'failures',
-    KEY__HEADER__SCHEMA_VERSION: 'schemaVersion',
-    KEY__HEADER__SET_A_DESCRIPTIONS: 'setA',
-    KEY__HEADER__SET_B_DESCRIPTIONS: 'setB',
-    KEY__HEADER__TIME_NEXT_UPDATE_AVAILABLE: 'timeNextUpdateAvailable',
-    KEY__HEADER__TIME_UPDATED: 'timeUpdated',
-    KEY__HEADER__TYPE: 'type',
-    VALUE__HEADER__SCHEMA_VERSION: 5,
-    //
-    KEY__RESULT_TYPE__FAILED: 'failed',
-    KEY__RESULT_TYPE__FAILUREIGNORED: 'failure-ignored',
-    KEY__RESULT_TYPE__NOCOMPARISON: 'no-comparison',
-    KEY__RESULT_TYPE__SUCCEEDED: 'succeeded',
-    //
-    KEY__SET_DESCRIPTIONS__DIR: 'dir',
-    KEY__SET_DESCRIPTIONS__REPO_REVISION: 'repoRevision',
-    KEY__SET_DESCRIPTIONS__SECTION: 'section',
-
-    // NOTE: Keep these in sync with ../server.py
-    KEY__EDITS__MODIFICATIONS: 'modifications',
-    KEY__EDITS__OLD_RESULTS_HASH: 'oldResultsHash',
-    KEY__EDITS__OLD_RESULTS_TYPE: 'oldResultsType',
-    KEY__LIVE_EDITS__MODIFICATIONS: 'modifications',
-    KEY__LIVE_EDITS__SET_A_DESCRIPTIONS: 'setA',
-    KEY__LIVE_EDITS__SET_B_DESCRIPTIONS: 'setB',
-
-    // These are just used on the client side, no need to sync with server code.
-    KEY__IMAGEPAIRS__ROWSPAN: 'rowspan',
-    URL_KEY__SCHEMA_VERSION: 'urlSchemaVersion',
-    URL_VALUE__SCHEMA_VERSION__CURRENT: 1,
-
-    // Utility constants only used on the client side. 
-    ASC: 'asc',
-    DESC: 'desc',
-  }
-})())