Adding keyboard service.

Adding keyboard service.

This allows to show the soft keyboard on Android.

Also updated platform_viewport_android to dispatch key events.

R=abarth@chromium.org
BUG=449002
Committed: https://chromium.googlesource.com/external/mojo/+/8555d638b8375f6bf6bb13cec546e415caf54861

[qsr, 2015-01-20 13:39:04]

Adam -> This is riddled with debug logs and everything so not ready to push at
all.

With this patch, the keyboard shows when you select an input on sky, and I can
see thanks to the comment that I received event at ui/events/event_source.cc

I also checked that I receive the same key event than linux.

*BUT*, there is no update of the text widget on android while it works on Linux,
so I'm obviously missing something, but I don't have a lot of knowledge on this
part of our system, do you have an idea where I should look at?

[abarth-chromium, 2015-01-20 17:42:40]

On 2015/01/20 at 13:39:04, qsr wrote:
> Adam -> This is riddled with debug logs and everything so not ready to push at
all.
> 
> With this patch, the keyboard shows when you select an input on sky, and I can
see thanks to the comment that I received event at ui/events/event_source.cc

Awesome!

> I also checked that I receive the same key event than linux.
> 
> *BUT*, there is no update of the text widget on android while it works on
Linux, so I'm obviously missing something, but I don't have a lot of knowledge
on this part of our system, do you have an idea where I should look at?

I'd add some logging to sky::DocumentView::OnInputEvent.  I bet Linux is
generating more events than this CL is.  Take a look at
<https://github.com/domokit/mojo/blob/master/sky/tests/resources/event-sender.sky>.
 Notice that we send two KEY_PRESSED events when we want to fake type, one with
is_char and one without.  Not sure what all that is about.  Might need some more
study.

[qsr, 2015-01-21 15:32:58]

> I'd add some logging to sky::DocumentView::OnInputEvent.  I bet Linux is
> generating more events than this CL is.  Take a look at
>
<https://github.com/domokit/mojo/blob/master/sky/tests/resources/event-sender.sky>.
>  Notice that we send two KEY_PRESSED events when we want to fake type, one
with
> is_char and one without.  Not sure what all that is about.  Might need some
more
> study.

 I already was sending 2 KEY_PRESSED for each real one, as I was listening to
linux event to make this work.

 The issue was with the focus. The sky view was never focused. I guess we have
some issue in window manager about focusing windows. I will look into this, but
this seems kind of correct for now. WDYT?

[qsr, 2015-01-21 15:33:05]

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input.sky
File sky/framework/sky-input.sky (right):

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input....
sky/framework/sky-input.sky:33: module.keyboard =
shell.connectToService("mojo:keyboard", keyboard.Keyboard);
What is the right way to set a service to be used by this module? This obviously
works, but makes this available to all dependency while this should be private.

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input....
sky/framework/sky-input.sky:64: module.keyboard.show();
Is that fine with you? Is there no change of this being overridden by
descendant? Are we sure that the blur event will happen before another input is
focused?

https://codereview.chromium.org/856063002/diff/20001/sky/viewer/document_view.cc
File sky/viewer/document_view.cc (right):

https://codereview.chromium.org/856063002/diff/20001/sky/viewer/document_view...
sky/viewer/document_view.cc:128: root_->SetFocus();
This seems very wrong. But given that you explicitly set the focus to true, I do
not think this is worst that what we have.

[abarth-chromium, 2015-01-21 17:43:58]

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input.sky
File sky/framework/sky-input.sky (right):

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input....
sky/framework/sky-input.sky:33: module.keyboard =
shell.connectToService("mojo:keyboard", keyboard.Keyboard);
On 2015/01/21 at 15:33:05, qsr wrote:
> What is the right way to set a service to be used by this module? This
obviously works, but makes this available to all dependency while this should be
private.

You can just store it in a variable:

var keyboard = shell.connectToService("mojo:keyboard", keyboard.Keyboard);

These sorts of variables are local to the module.

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input....
sky/framework/sky-input.sky:64: module.keyboard.show();
On 2015/01/21 at 15:33:05, qsr wrote:
> Is that fine with you?

Yeah, this looks right.

> Is there no change of this being overridden by descendant?

It could be, but that's fine.  It's something that you'd expect to break.

> Are we sure that the blur event will happen before another input is focused?

It should!

[qsr, 2015-01-21 18:13:16]

It is now ready to review.

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input.sky
File sky/framework/sky-input.sky (right):

https://codereview.chromium.org/856063002/diff/20001/sky/framework/sky-input....
sky/framework/sky-input.sky:33: module.keyboard =
shell.connectToService("mojo:keyboard", keyboard.Keyboard);
On 2015/01/21 17:43:58, abarth wrote:
> On 2015/01/21 at 15:33:05, qsr wrote:
> > What is the right way to set a service to be used by this module? This
> obviously works, but makes this available to all dependency while this should
be
> private.
> 
> You can just store it in a variable:
> 
> var keyboard = shell.connectToService("mojo:keyboard", keyboard.Keyboard);
> 
> These sorts of variables are local to the module.

Done.

[abarth-chromium, 2015-01-21 19:09:16]

lgtm

[qsr, 2015-01-22 09:19:13]

Committed patchset #3 (id:40001) manually as
8555d638b8375f6bf6bb13cec546e415caf54861 (presubmit successful).