runtime/lib/internal_patch.dart - Issue 856053002: Let Uint16List.setRange detect a String.codeUnits object, and copy directly from the string.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/internal_patch.dart

Issue 856053002: Let Uint16List.setRange detect a String.codeUnits object, and copy directly from the string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move CodeUnits.cid to VM-only patch file. It makes no sense for dart2js Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 patch List makeListFixedLength(List growableList)	5 patch List makeListFixedLength(List growableList)

6 native "Internal_makeListFixedLength";	6 native "Internal_makeListFixedLength";

7	7

8 class VMLibraryHooks {	8 class VMLibraryHooks {

9 // Example: "dart:isolate _Timer._factory"	9 // Example: "dart:isolate _Timer._factory"

10 static var timerFactory;	10 static var timerFactory;

11 // Example: "dart:io _EventHandler._sendData"	11 // Example: "dart:io _EventHandler._sendData"

12 static var eventHandlerSendData;	12 static var eventHandlerSendData;

13 }	13 }

	14

	15 patch class CodeUnits {

	16 static final int cid = ClassID.getID(new CodeUnits(""));
	Vyacheslav Egorov (Google) 2015/01/29 13:04:54 Maybe implement ClassID.getClassId(Type) and use t Maybe implement ClassID.getClassId(Type) and use that instead? Lasse Reichstein Nielsen 2015/01/29 13:13:27 I think that's a great idea, but not something I t I think that's a great idea, but not something I think I'll be able to pull off. Not for this CL for sure.
	17 }

OLD	NEW

« no previous file with comments | « no previous file | runtime/lib/string_patch.dart » ('j') | runtime/lib/typed_data.dart » ('J')