Fixed running gdb on rooted device

Fixed running gdb on rooted device

The command passed as a parameter to some implementations of "su" must
be enclosed in quotation marks. Otherwise, the command contains spaces,
can be splited into several commands. For example 'su -c echo foo' can
be executed by "su" as two commands: "echo" and "foo". The right way to
run this is 'su -c "echo foo"'. This patch fixes "su" behaviour and
still works fine without --su-prefix flag

Added quotes around adb shell command

R=jbudorick@chromium.org, klundberg@chromium.org
TEST=Run build/android/adb_gdb with parameter --su-prefix="su -c", on device which is rooted with "SuperSU v1.99 - Copyright (C) 2012-2014 - Chainfire"

Committed: https://crrev.com/8fe7481f6b9d9c4012390b959fc7a305111a5a23
Cr-Commit-Position: refs/heads/master@{#312845}

[jbudorick, 2015-01-20 14:23:20]

lgtm

[ripp, 2015-01-23 08:14:44]

Hello.
Is this ok to initiate commit, or I should wait for LGTM from klundberg?

[jbudorick, 2015-01-23 14:02:49]

On 2015/01/23 08:14:44, ripp wrote:
> Hello.
> Is this ok to initiate commit, or I should wait for LGTM from klundberg?

It's ok to send this into the CQ.

[ripp, 2015-01-23 14:04:46]

The CQ bit was checked by ripp@yandex-team.ru

[commit-bot: I haz the power, 2015-01-23 14:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/855943002/1

[commit-bot: I haz the power, 2015-01-23 14:52:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-23 14:53:28]

Patchset 1 (id:??) landed as
https://crrev.com/8fe7481f6b9d9c4012390b959fc7a305111a5a23
Cr-Commit-Position: refs/heads/master@{#312845}

[Feng Qian, 2015-01-26 21:33:30]

On 2015/01/23 14:53:28, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/8fe7481f6b9d9c4012390b959fc7a305111a5a23
> Cr-Commit-Position: refs/heads/master@{#312845}

This CL breaks normal 'adb_gdb_command':

Command prefix: ''
....
adb shell  "/data/local/tmp/gdbserver-adb-gdb-32726 :5039 --attach 28144"
background job pid: 366
Job control: [1]+   366 Done                    ( "$ADB" shell $COMMAND_PREFIX
\"$TARGET_GDBSERVER :$TARGET_PORT --attach $PID\" > $GDBSERVER_LOG 2>&1 )
ERROR: GDBServer could not attach to PID 28144!
Failure log (use --verbose for more information):
/system/bin/sh: no closing quote
...