Allow universal access from file if flag is set and url is file scheme.

content/browser/frame_host/navigation_controller_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
@@ skipping 3187 matching lines @@
 
   // Don't believe the renderer if it claims a cross-origin navigation is
   // in-page.
   const GURL different_origin_url("http://www.example.com");
   MockRenderProcessHost* rph =
       static_cast<MockRenderProcessHost*>(main_test_rfh()->GetProcess());
   EXPECT_EQ(0, rph->bad_msg_count());
   EXPECT_FALSE(controller.IsURLInPageNavigation(different_origin_url, true,
       main_test_rfh()));
   EXPECT_EQ(1, rph->bad_msg_count());
+
+  // Test allow_universal_access_from_file_urls flag

[Charlie Reis, 2015/01/23 06:53:37]

nit: End with period.

[nhu, 2015/01/23 13:41:13]

Done.

+  WebPreferences prefs =
+      main_test_rfh()->GetRenderViewHost()->GetWebkitPreferences();

[Charlie Reis, 2015/01/23 06:53:37]

test_rvh()  (here and below)

[nhu, 2015/01/23 13:41:13]

Done.

+  EXPECT_EQ(false, prefs.allow_universal_access_from_file_urls);
+  prefs.allow_universal_access_from_file_urls = true;
+  main_test_rfh()->GetRenderViewHost()->UpdateWebkitPreferences(prefs);
+  prefs =
+      main_test_rfh()->GetRenderViewHost()->GetWebkitPreferences();
+  EXPECT_EQ(true, prefs.allow_universal_access_from_file_urls);
+  // Don't hornor allow_universal_access_from_file_urls if existing URL is

[Charlie Reis, 2015/01/23 06:53:37]

honor

[nhu, 2015/01/23 13:41:13]

Done.

+  // not file scheme.
+  EXPECT_EQ(1, rph->bad_msg_count());
+  EXPECT_FALSE(controller.IsURLInPageNavigation(different_origin_url, true,
+      main_test_rfh()));
+  EXPECT_EQ(2, rph->bad_msg_count());
+  // Allow in page navigation if existing URL is file scheme.

[Charlie Reis, 2015/01/23 06:53:37]

Move this case above the bad_msg_count case, so that we can ensure that
bad_msg_count is 0 when it works.

[nhu, 2015/01/23 13:41:13]

It makes sense. I reordered them. Does it look better?

+  const GURL file_url("file:///foo/index.html");
+  main_test_rfh()->SendNavigate(0, file_url);
+  EXPECT_EQ(2, rph->bad_msg_count());
+  EXPECT_TRUE(controller.IsURLInPageNavigation(different_origin_url, true,
+      main_test_rfh()));
+  EXPECT_EQ(2, rph->bad_msg_count());
 }
 
 // Some pages can have subframes with the same base URL (minus the reference) as
 // the main page. Even though this is hard, it can happen, and we don't want
 // these subframe navigations to affect the toplevel document. They should
 // instead be ignored.  http://crbug.com/5585
 TEST_F(NavigationControllerTest, SameSubframe) {
   NavigationControllerImpl& controller = controller_impl();
   // Navigate the main frame.
   const GURL url("http://www.google.com/");
@@ skipping 1198 matching lines @@
   params.post_id = -1;
   contents()->GetMainFrame()->SendNavigateWithParams(&params);
 
   // Now reload. replaceState overrides the POST, so we should not show a
   // repost warning dialog.
   controller_impl().Reload(true);
   EXPECT_EQ(0, delegate->repost_form_warning_count());
 }
 
 }  // namespace content