cc/resources/tile_manager.h - Issue 855843002: [cc] replacing left out COMPILE_ASSERT with static_assert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/tile_manager.h

Issue 855843002: [cc] replacing left out COMPILE_ASSERT with static_assert (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Checking alignments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/tile_manager.h

diff --git a/cc/resources/tile_manager.h b/cc/resources/tile_manager.h

index f1d00fee884078742f669ac463371c3c3790f814..608c7960eaf64cde3e25e8555485db2b55eb6886 100644

--- a/cc/resources/tile_manager.h

+++ b/cc/resources/tile_manager.h

@@ -99,8 +99,9 @@ class CC_EXPORT TileManager : public TileTaskRunnerClient,

// rasterizer.h

};

- COMPILE_ASSERT(NamedTaskSet::ALL == (kNumberOfTaskSets - 1),

- NamedTaskSet_ALL_not_kNumberOfTaskSets_minus_1);

+ static_assert(NamedTaskSet::ALL == (kNumberOfTaskSets - 1),

+ "NamedTaskSet ALL should be equal or greater then that of"

Mostyn Bramley-Moore 2015/01/19 17:20:46 This is not a >= check. Aslo, nitpick: "NamedTask

anujsharma 2015/01/20 03:11:01 Thanks for your review. Fixed the comments!!

+ "kNumberOfTaskSets");

static scoped_ptr<TileManager> Create(TileManagerClient* client,

base::SequencedTaskRunner* task_runner,

« no previous file with comments | « no previous file | no next file » | no next file with comments »