Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: extensions/renderer/resources/send_request.js

Issue 855813002: Mark create/update/clear callbacks of notification API as optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/send_request.js
diff --git a/extensions/renderer/resources/send_request.js b/extensions/renderer/resources/send_request.js
index 7cdc7d16936a19a267258e217ccc4fd0a853433c..a97dee54a001cfc603e8708027e2528feab6adc6 100644
--- a/extensions/renderer/resources/send_request.js
+++ b/extensions/renderer/resources/send_request.js
@@ -78,10 +78,7 @@ function handleResponse(requestId, name, success, responseList, error) {
!lastError.hasAccessed(callerChrome)) {
// The native call caused an error, but the developer didn't check
// runtime.lastError.
- // Notify the developer of the error via the (error) console.
- console.error("Unchecked runtime.lastError while running " +
- (name || "unknown") + ": " + error +
- (request.stack ? "\n" + request.stack : ""));
+ lastError.reportUncheckedLastError(name, error, request.stack);
}
} finally {
delete requests[requestId];
@@ -120,12 +117,14 @@ function prepareRequest(args, argSchemas) {
// - forIOThread: true if this function should be handled on the browser IO
// thread.
// - preserveNullInObjects: true if it is safe for null to be in objects.
+// - stack: An optional string that contains the stack trace, to be displayed
+// to the user if an error occurs.
function sendRequest(functionName, args, argSchemas, optArgs) {
calledSendRequest = true;
if (!optArgs)
optArgs = {};
var request = prepareRequest(args, argSchemas);
- request.stack = exceptionHandler.getExtensionStackTrace();
+ request.stack = optArgs.stack || exceptionHandler.getExtensionStackTrace();
if (optArgs.customCallback) {
request.customCallback = optArgs.customCallback;
}
« extensions/renderer/resources/last_error.js ('K') | « extensions/renderer/resources/last_error.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698