Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: sky/engine/core/html/HTMLImageElement.cpp

Issue 855803002: Remove attrs sky doesn't support. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/html/HTMLAttributeNames.in ('k') | sky/engine/core/html/HTMLImageElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLImageElement.cpp
diff --git a/sky/engine/core/html/HTMLImageElement.cpp b/sky/engine/core/html/HTMLImageElement.cpp
index 9afecf121bc1e772e2570f05549b76672efa0266..3e3d706dc546944ac6f792dcc5be66caac1fd30f 100644
--- a/sky/engine/core/html/HTMLImageElement.cpp
+++ b/sky/engine/core/html/HTMLImageElement.cpp
@@ -137,7 +137,7 @@ void HTMLImageElement::setBestFitURLAndDPRFromImageCandidate(const ImageCandidat
void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (name == HTMLNames::srcAttr || name == HTMLNames::srcsetAttr || name == HTMLNames::sizesAttr) {
+ if (name == HTMLNames::srcAttr) {
selectSourceURL(ImageLoader::UpdateIgnorePreviousError);
} else {
HTMLElement::parseAttribute(name, value);
@@ -361,7 +361,7 @@ void HTMLImageElement::selectSourceURL(ImageLoader::UpdateFromElementBehavior be
unsigned effectiveSize = 0;
ImageCandidate candidate = bestFitSourceForImageAttributes(
document().devicePixelRatio(), effectiveSize,
- getAttribute(HTMLNames::srcAttr), getAttribute(HTMLNames::srcsetAttr));
+ getAttribute(HTMLNames::srcAttr), AtomicString());
setBestFitURLAndDPRFromImageCandidate(candidate);
if (m_intrinsicSizingViewportDependant && m_effectiveSizeViewportDependant && !m_listener.get()) {
m_listener = ViewportChangeListener::create(this);
« no previous file with comments | « sky/engine/core/html/HTMLAttributeNames.in ('k') | sky/engine/core/html/HTMLImageElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698