Issue 855803002: Remove attrs sky doesn't support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 855803002: Remove attrs sky doesn't support. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove attrs sky doesn't support. This removes the attributes sky doesn't intend to support. It removes references to the attrs, but leaves behind a lot of plumbing that will be cleaned up in the future. This at least removes the API surface. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/154bfe974bb667675347d426c7a2156b66f12c0c

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -133 lines)			Patch
M	sky/engine/core/dom/Element.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/dom/Element.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/dom/TreeScope.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/TreeScope.cpp	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	sky/engine/core/html/HTMLAttributeNames.in	View	1 chunk	+20 lines, -17 lines	0 comments	Download
M	sky/engine/core/html/HTMLImageElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/html/HTMLImageElement.idl	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/loader/ImageLoader.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/page/Chrome.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	sky/engine/core/page/EventHandler.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/page/EventHandler.cpp	View	4 chunks	+1 line, -39 lines	0 comments	Download
M	sky/engine/core/rendering/HitTestResult.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/rendering/HitTestResult.cpp	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

esprehn

5 years, 11 months ago (2015-01-17 03:42:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
154bfe974bb667675347d426c7a2156b66f12c0c (presubmit successful).