Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 855753004: Remove remainder of Athena related code from Chrome (Closed)

Created:
5 years, 11 months ago by pkotwicz
Modified:
5 years, 11 months ago
Reviewers:
James Cook, sky, scottmg
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, tfarina, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_USE_ATHENA5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remainder of Athena related code from Chrome. This CL: - Removes athena dependencies from build files for the chrome target - Removes athena-specific files in chrome/ BUG=440818 TEST=None R=sky,scottmg TBR=jamescook (for change to comment in extensions/shell/browser/desktop_controller.h) Committed: https://crrev.com/5748e135876286766151600a96283d369dba6584 Cr-Commit-Position: refs/heads/master@{#312282}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -954 lines) Patch
M build/all.gyp View 1 7 chunks +9 lines, -39 lines 0 comments Download
M build/common.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/ui.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/extensions/api/tabs/tabs_api_athena.cc View 1 chunk +0 lines, -360 lines 0 comments Download
D chrome/browser/extensions/display_info_provider_athena.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/extensions/display_info_provider_athena.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/extensions/extension_tab_util_athena.cc View 1 chunk +0 lines, -234 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/ash_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/athena/extensions/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/athena/extensions/extension_install_ui_factory_athena.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/ui/views/athena/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/ui/views/athena/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/athena/athena_util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/views/athena/athena_util.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 5 chunks +4 lines, -18 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 8 chunks +19 lines, -53 lines 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_repack_locales.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/schemas.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 5 chunks +0 lines, -10 lines 0 comments Download
M extensions/shell/browser/desktop_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/check_grd_for_unused_strings.py View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
pkotwicz
sky@ PTAL
5 years, 11 months ago (2015-01-18 19:23:59 UTC) #5
sky
LGTM
5 years, 11 months ago (2015-01-20 16:28:09 UTC) #6
pkotwicz
scottmg@ for changes in build/
5 years, 11 months ago (2015-01-20 18:35:15 UTC) #9
scottmg
lgtm
5 years, 11 months ago (2015-01-20 18:47:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855753004/80001
5 years, 11 months ago (2015-01-20 18:53:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37061) Try jobs failed on following ...
5 years, 11 months ago (2015-01-20 19:02:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855753004/80001
5 years, 11 months ago (2015-01-20 20:47:02 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37061)
5 years, 11 months ago (2015-01-20 20:47:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855753004/80001
5 years, 11 months ago (2015-01-20 21:51:10 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 11 months ago (2015-01-20 21:53:13 UTC) #22
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 21:54:11 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5748e135876286766151600a96283d369dba6584
Cr-Commit-Position: refs/heads/master@{#312282}

Powered by Google App Engine
This is Rietveld 408576698