Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 855723002: Revert of Revert of [turbofan] Improve memory layout of Node class. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/856813003/) Reason for revert: Revert didn't help. Original issue's description: > Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/828803004/) > > Reason for revert: > Speculative revert to see if win XP recovers. Will reland if not. > > Original issue's description: > > [turbofan] Improve memory layout of Node class. > > > > Also gets rid of the reinterpret_cast on this. > > > > R=svenpanne@chromium.org > > > > Committed: https://crrev.com/f91e8046fad99365c74ccbb39d42de58398dab57 > > Cr-Commit-Position: refs/heads/master@{#26103} > > TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/dc6f34d83650dce8faa3e82e87c050f12732d4b3 > Cr-Commit-Position: refs/heads/master@{#26106} TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/57872da9aceff231bf9d48bb69b67973c6ae209f Cr-Commit-Position: refs/heads/master@{#26107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M src/compiler/node.h View 2 chunks +10 lines, -9 lines 0 comments Download
M src/compiler/node.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert of [turbofan] Improve memory layout of Node class.
5 years, 11 months ago (2015-01-16 19:17:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855723002/1
5 years, 11 months ago (2015-01-16 19:17:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 19:18:03 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 19:18:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57872da9aceff231bf9d48bb69b67973c6ae209f
Cr-Commit-Position: refs/heads/master@{#26107}

Powered by Google App Engine
This is Rietveld 408576698