Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 855653003: GPU Traces now use synchronous traces for detailed CPU Wall times. (Closed)

Created:
5 years, 11 months ago by David Yen
Modified:
5 years, 11 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GPU Traces now use synchronous traces for detailed CPU Wall times. R=vmiura@chromium.org BUG=None TEST=trybots Committed: https://crrev.com/81aaafd1b2ec990e3e1823d7aefddc5eb81276d7 Cr-Commit-Position: refs/heads/master@{#311960}

Patch Set 1 #

Patch Set 2 : Removed unnecessary id argument from outputter #

Patch Set 3 : Fixed some issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -28 lines) Patch
M gpu/command_buffer/service/gpu_tracer.h View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 1 3 chunks +8 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 1 2 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
David Yen
5 years, 11 months ago (2015-01-16 18:54:50 UTC) #1
vmiura
LGTM.
5 years, 11 months ago (2015-01-16 20:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855653003/40001
5 years, 11 months ago (2015-01-16 21:28:53 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-16 21:51:39 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 21:52:31 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/81aaafd1b2ec990e3e1823d7aefddc5eb81276d7
Cr-Commit-Position: refs/heads/master@{#311960}

Powered by Google App Engine
This is Rietveld 408576698