Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 855653002: [turbofan] Improve loop analysis to handle more than 32 loops. (Closed)

Created:
5 years, 11 months ago by titzer
Modified:
5 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve loop analysis to handle more than 32 loops. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/36003d07eb650d8c2dddae95ad136aac17c83c0c Cr-Commit-Position: refs/heads/master@{#26140}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -129 lines) Patch
M src/compiler/loop-analysis.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/loop-analysis.cc View 1 2 3 9 chunks +177 lines, -123 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 5 chunks +100 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
titzer
5 years, 11 months ago (2015-01-16 13:50:18 UTC) #1
Michael Starzinger
LGTM. Stared long and hard at the matrix index computations, couldn't find any bugs, but ...
5 years, 11 months ago (2015-01-19 12:51:21 UTC) #2
titzer
https://codereview.chromium.org/855653002/diff/1/src/compiler/loop-analysis.cc File src/compiler/loop-analysis.cc (right): https://codereview.chromium.org/855653002/diff/1/src/compiler/loop-analysis.cc#newcode17 src/compiler/loop-analysis.cc:17: #define OFFSET(x) ((x)&0x1f) On 2015/01/19 12:51:20, Michael Starzinger wrote: ...
5 years, 11 months ago (2015-01-19 12:54:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855653002/20001
5 years, 11 months ago (2015-01-19 12:56:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/1253)
5 years, 11 months ago (2015-01-19 13:54:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855653002/40001
5 years, 11 months ago (2015-01-19 14:06:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/1256)
5 years, 11 months ago (2015-01-19 14:25:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855653002/60001
5 years, 11 months ago (2015-01-19 14:52:16 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-19 15:19:51 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 15:20:07 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/36003d07eb650d8c2dddae95ad136aac17c83c0c
Cr-Commit-Position: refs/heads/master@{#26140}

Powered by Google App Engine
This is Rietveld 408576698