Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 855643005: [CSS Grid Layout] Handling overflow on Content Alignment properties. (Closed)

Created:
5 years, 11 months ago by jfernandez
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Handling overflow on Content Alignment properties. The Content Alignment syntax defined in the Box Alignment specification allows using the Overflow Alignment keyword as part of the align-content and justify-content values. This patch implements the logic to handle the cases where the grid tracks overflow the grid container boundaries. BUG=376823 249451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188985

Patch Set 1 #

Total comments: 1

Patch Set 2 : Applied suggested changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -13 lines) Patch
A LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html View 1 1 chunk +135 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 5 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jfernandez
5 years, 11 months ago (2015-01-22 10:36:29 UTC) #2
Julien - ping for review
lgtm https://codereview.chromium.org/855643005/diff/1/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html File LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html (right): https://codereview.chromium.org/855643005/diff/1/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html#newcode26 LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html:26: .noOverflow { This is unused.
5 years, 11 months ago (2015-01-26 16:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855643005/20001
5 years, 11 months ago (2015-01-26 17:35:29 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 18:52:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188985

Powered by Google App Engine
This is Rietveld 408576698