Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 855603002: Roll Web Page Replay to pick-up HTTPS certificate fixes. (Closed)

Created:
5 years, 11 months ago by slamm
Modified:
5 years, 10 months ago
Reviewers:
wuhu, sullivan, tonyg, vmiura
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Web Page Replay to pick-up HTTPS certificate fixes. Includes fixes for: Generated certificates use different common name than original. https://github.com/chromium/web-page-replay/issues/37 Replay uses wrong root CA during replay. https://github.com/chromium/web-page-replay/issues/38 Android: Error installing cert from Mac host https://code.google.com/p/chromium/issues/detail?id=431686 BUG=431686 Committed: https://crrev.com/aa498cbeed50f119e76f08d2681b136325f191df Cr-Commit-Position: refs/heads/master@{#311829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
slamm
5 years, 11 months ago (2015-01-16 00:33:29 UTC) #2
slamm
Annie are you the best person for Web Page Replay issues now?
5 years, 11 months ago (2015-01-16 00:34:56 UTC) #4
chromium-reviews
BTW, with this change, replayed Android benchmarks do not use --ignore-certificate-errors. On Thu, Jan 15, ...
5 years, 11 months ago (2015-01-16 00:36:44 UTC) #5
sullivan
lgtm I can review or route WPR changes.
5 years, 11 months ago (2015-01-16 00:44:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855603002/1
5 years, 11 months ago (2015-01-16 03:14:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 03:18:51 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa498cbeed50f119e76f08d2681b136325f191df Cr-Commit-Position: refs/heads/master@{#311829}
5 years, 11 months ago (2015-01-16 03:19:50 UTC) #11
Yufeng Shen (Slow to review)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/874483004/ by miletus@chromium.org. ...
5 years, 11 months ago (2015-01-23 19:01:06 UTC) #12
slamm
5 years, 10 months ago (2015-01-31 00:33:06 UTC) #13
Message was sent while issue was closed.
Roll Web Page Replay and still use --ignore-certificate-errors if device clock
is off.

Powered by Google App Engine
This is Rietveld 408576698