Isolate/Thread split: Isolate -> Zone for LocationSummary.

Isolate/Thread split: Isolate -> Zone for LocationSummary.

The isolate was being passed around, even though only its current zone was used.

Pass that zone directly instead, giving two benefits:
1. helps prepare for the upcoming Isolate/Thread split, where "new(isolate)" must go, and
2. saves a pointer indirection at the allocation sites.

Committed: https://code.google.com/p/dart/source/detail?r=42935

[Ivan Posva, 2015-01-15 20:35:40]

LGTMwC

-Ivan

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_al...
File runtime/vm/flow_graph_allocator.cc (right):

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_al...
runtime/vm/flow_graph_allocator.cc:167:
current->InitializeLocationSummary(Isolate::Current()->current_zone(),
SSALivenessAnalysis or even better its base class LivenessAnalysis should have a
isolate field for avoiding the Isolate::Current() call. Alternatively if the
isolate is not needed, then a zone field would be appropriate.

Probably the same for the other calls to Isolate::Current() in this file.

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_co...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_co...
runtime/vm/flow_graph_compiler.cc:1128:
instr->InitializeLocationSummary(isolate()->current_zone(),
In a lot of files we have added the following lines to get less visually
disturbing access to the isolate() field:
// Quick access to the locally defined isolate() method.
#define I (isolate())

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:8038: Zone* zone, bool opt) const {          
                                \
Does this now fit on one line?

[koda, 2015-01-15 21:29:12]

Also ported to all archs.

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_al...
File runtime/vm/flow_graph_allocator.cc (right):

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_al...
runtime/vm/flow_graph_allocator.cc:167:
current->InitializeLocationSummary(Isolate::Current()->current_zone(),
On 2015/01/15 20:35:39, Ivan Posva wrote:
> SSALivenessAnalysis or even better its base class LivenessAnalysis should have
a
> isolate field for avoiding the Isolate::Current() call. Alternatively if the
> isolate is not needed, then a zone field would be appropriate.
> 
> Probably the same for the other calls to Isolate::Current() in this file.

Done.

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_co...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/flow_graph_co...
runtime/vm/flow_graph_compiler.cc:1128:
instr->InitializeLocationSummary(isolate()->current_zone(),
On 2015/01/15 20:35:39, Ivan Posva wrote:
> In a lot of files we have added the following lines to get less visually
> disturbing access to the isolate() field:
> // Quick access to the locally defined isolate() method.
> #define I (isolate())

Done.

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/855533002/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:8038: Zone* zone, bool opt) const {          
                                \
On 2015/01/15 20:35:39, Ivan Posva wrote:
> Does this now fit on one line?

Done.

[koda, 2015-01-15 21:30:11]

Committed patchset #3 (id:40001) manually as r42935 (presubmit successful).