Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6022)

Unified Diff: chrome/browser/safe_image_fetcher.cc

Issue 855513002: Add/resurrect support for bundles of WebStore items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@testext_bundle
Patch Set: add CRXs Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_image_fetcher.cc
diff --git a/chrome/browser/safe_image_fetcher.cc b/chrome/browser/safe_image_fetcher.cc
new file mode 100644
index 0000000000000000000000000000000000000000..78ba350d2f9a5f98662c21e46bd08d1e0f58971a
--- /dev/null
+++ b/chrome/browser/safe_image_fetcher.cc
@@ -0,0 +1,64 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_image_fetcher.h"
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "net/base/load_flags.h"
+#include "net/url_request/url_fetcher.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+
+SafeImageFetcher::SafeImageFetcher(
+ const GURL& url,
+ net::URLRequestContextGetter* context_getter,
+ const GetImageCallback& callback)
+ : ImageRequest(base::MessageLoopProxy::current()),
+ callback_(callback),
+ weak_ptr_factory_(this) {
+ if (url.is_valid()) {
+ DCHECK(context_getter);
+ url_fetcher_.reset(net::URLFetcher::Create(
+ url, net::URLFetcher::GET, this));
+ url_fetcher_->SetRequestContext(context_getter);
+ url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |
+ net::LOAD_DO_NOT_SEND_COOKIES);
+
+ url_fetcher_->Start();
+ // We'll get called back in OnURLFetchComplete.
+ } else {
+ base::MessageLoopProxy::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&SafeImageFetcher::OnDecodeImageFailed,
+ weak_ptr_factory_.GetWeakPtr()));
+ }
+}
+
+SafeImageFetcher::~SafeImageFetcher() {
+}
+
+void SafeImageFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
+ DCHECK_EQ(url_fetcher_.get(), source);
+ int response_code =
+ source->GetStatus().is_success() ? source->GetResponseCode() : 0;
+ if (!source->GetStatus().is_success() ||
+ response_code / 100 == 4 || response_code / 100 == 5) {
Lei Zhang 2015/03/31 09:39:08 So if we somehow get respond code 900, that counts
Marc Treib 2015/03/31 12:48:21 Hm, I'm guessing is_success() wouldn't be true in
+ OnDecodeImageFailed();
+ } else {
+ std::string response_data;
+ source->GetResponseAsString(&response_data);
+
+ ImageDecoder::Start(this, response_data);
+ }
+ url_fetcher_.reset();
+}
+
+void SafeImageFetcher::OnImageDecoded(const SkBitmap& decoded_image) {
+ callback_.Run(decoded_image);
+}
+
+void SafeImageFetcher::OnDecodeImageFailed() {
+ callback_.Run(SkBitmap());
+}

Powered by Google App Engine
This is Rietveld 408576698