Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 855513002: Add/resurrect support for bundles of WebStore items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@testext_bundle
Patch Set: remove icon_data Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
index 88133f8fd0f4d66ac3a419dadbb37449b3a9623d..d42ba95a4e611bbf2479c252834b6e32f1ba0f1f 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
@@ -132,6 +132,8 @@ bool ExtensionInstalledBubbleBridge::MaybeShowNow() {
}
- (const Extension*)extension {
+ if (type_ == extension_installed_bubble::kBundle)
+ return nullptr;
return installedBubble_->extension();
}
@@ -152,6 +154,8 @@ bool ExtensionInstalledBubbleBridge::MaybeShowNow() {
// Returns YES if the sync promo should be shown in the bubble.
- (BOOL)showSyncPromo {
+ if (type_ == extension_installed_bubble::kBundle)
+ return false;
return extensions::sync_helper::IsSyncableExtension([self extension]) &&
SyncPromoUI::ShouldShowSyncPromo(browser_->profile());
}
@@ -441,7 +445,8 @@ bool ExtensionInstalledBubbleBridge::MaybeShowNow() {
newWindowHeight += sync_promo_height;
}
- if (installedBubble_->has_command_keybinding()) {
+ if (type_ != extension_installed_bubble::kBundle &&
+ installedBubble_->has_command_keybinding()) {
[manageShortcutLink_ setHidden:NO];
[[manageShortcutLink_ cell]
setFont:[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]];

Powered by Google App Engine
This is Rietveld 408576698