Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 855503002: Remove remainder of USE_ATHENA ifdefs (Closed)

Created:
5 years, 11 months ago by pkotwicz
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, marja+watch_chromium.org, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_USE_ATHENA3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remainder of USE_ATHENA ifdefs BUG=440818 TEST=None Committed: https://crrev.com/afd6d92c4bd52b46fa70bab5b962b5d75f8cef55 Cr-Commit-Position: refs/heads/master@{#311776}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -143 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/fullscreen_chromeos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_talk_host.cc View 4 chunks +4 lines, -5 lines 2 comments Download
M chrome/browser/sessions/session_data_deleter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
pkotwicz
sky@ PTAL. .gyp files are up next
5 years, 11 months ago (2015-01-15 02:41:20 UTC) #2
sky
https://codereview.chromium.org/855503002/diff/1/chrome/browser/renderer_host/pepper/pepper_talk_host.cc File chrome/browser/renderer_host/pepper/pepper_talk_host.cc (right): https://codereview.chromium.org/855503002/diff/1/chrome/browser/renderer_host/pepper/pepper_talk_host.cc#newcode83 chrome/browser/renderer_host/pepper/pepper_talk_host.cc:83: #if defined(OS_CHROMEOS) What about the USE_ASH here and the ...
5 years, 11 months ago (2015-01-15 16:28:34 UTC) #3
pkotwicz
https://codereview.chromium.org/855503002/diff/1/chrome/browser/renderer_host/pepper/pepper_talk_host.cc File chrome/browser/renderer_host/pepper/pepper_talk_host.cc (right): https://codereview.chromium.org/855503002/diff/1/chrome/browser/renderer_host/pepper/pepper_talk_host.cc#newcode83 chrome/browser/renderer_host/pepper/pepper_talk_host.cc:83: #if defined(OS_CHROMEOS) Am I missing something? Is it possible ...
5 years, 11 months ago (2015-01-15 16:44:10 UTC) #4
sky
Sorry, you're right. LGTM
5 years, 11 months ago (2015-01-15 17:09:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855503002/1
5 years, 11 months ago (2015-01-15 19:12:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/45674) Try jobs failed on following ...
5 years, 11 months ago (2015-01-15 19:59:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855503002/1
5 years, 11 months ago (2015-01-15 22:17:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/45674)
5 years, 11 months ago (2015-01-15 22:52:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855503002/1
5 years, 11 months ago (2015-01-15 23:32:37 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:33:01 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:34:15 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/afd6d92c4bd52b46fa70bab5b962b5d75f8cef55
Cr-Commit-Position: refs/heads/master@{#311776}

Powered by Google App Engine
This is Rietveld 408576698