Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8555001: base::Bind: Convert chrome_frame/. (Closed)

Created:
9 years, 1 month ago by James Hawkins
Modified:
9 years, 1 month ago
Reviewers:
csilv, awong
CC:
chromium-reviews, amit
Visibility:
Public.

Description

base::Bind: Convert chrome_frame/. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110744

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Bad merge. #

Total comments: 4

Patch Set 4 : Review fix. #

Patch Set 5 : TaskMarshaller fix. #

Total comments: 2

Patch Set 6 : Compile fix. #

Patch Set 7 : Review fix. #

Patch Set 8 : More win fix. #

Patch Set 9 : Win fix X. #

Patch Set 10 : Win fix X2. #

Patch Set 11 : Win fix 99. #

Patch Set 12 : Win fixxxx. #

Patch Set 13 : This sucks. #

Patch Set 14 : Moar. #

Patch Set 15 : Win-dies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -197 lines) Patch
M base/threading/worker_pool.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +22 lines, -11 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 2 3 4 5 6 7 8 9 11 chunks +35 lines, -27 lines 0 comments Download
M chrome_frame/chrome_frame_delegate.h View 1 2 3 4 5 6 7 9 chunks +23 lines, -21 lines 0 comments Download
M chrome_frame/custom_sync_call_context.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/external_tab_test.cc View 3 chunks +25 lines, -18 lines 0 comments Download
M chrome_frame/task_marshaller.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome_frame/task_marshaller.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 1 3 chunks +5 lines, -8 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +10 lines, -4 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome_frame/test/infobar_unittests.cc View 1 2 3 3 chunks +6 lines, -11 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +33 lines, -27 lines 0 comments Download
M chrome_frame/test/proxy_factory_mock.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome_frame/test/test_server.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M chrome_frame/test/url_request_test.cc View 1 3 chunks +11 lines, -10 lines 0 comments Download
M chrome_frame/test/win_event_receiver.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/urlmon_url_request.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 1 2 3 4 5 6 7 8 9 10 11 12 9 chunks +22 lines, -26 lines 0 comments Download
M chrome_frame/urlmon_url_request_private.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
James Hawkins
9 years, 1 month ago (2011-11-13 02:56:58 UTC) #1
James Hawkins
9 years, 1 month ago (2011-11-18 00:36:28 UTC) #2
csilv
http://codereview.chromium.org/8555001/diff/4020/chrome_frame/test/infobar_unittests.cc File chrome_frame/test/infobar_unittests.cc (right): http://codereview.chromium.org/8555001/diff/4020/chrome_frame/test/infobar_unittests.cc#newcode411 chrome_frame/test/infobar_unittests.cc:411: loop->PostDelayedTask( should be 'PostTask' http://codereview.chromium.org/8555001/diff/4020/chrome_frame/test/infobar_unittests.cc#newcode413 chrome_frame/test/infobar_unittests.cc:413: base::Bind(&InfobarManager::Hide,base::Unretained(manager), TOP_INFOBAR)); nit: ...
9 years, 1 month ago (2011-11-18 01:24:17 UTC) #3
James Hawkins
http://codereview.chromium.org/8555001/diff/4020/chrome_frame/test/infobar_unittests.cc File chrome_frame/test/infobar_unittests.cc (right): http://codereview.chromium.org/8555001/diff/4020/chrome_frame/test/infobar_unittests.cc#newcode411 chrome_frame/test/infobar_unittests.cc:411: loop->PostDelayedTask( On 2011/11/18 01:24:17, csilv wrote: > should be ...
9 years, 1 month ago (2011-11-18 01:30:15 UTC) #4
James Hawkins
+ajwong for TaskMarshaller fix
9 years, 1 month ago (2011-11-18 02:09:19 UTC) #5
csilv
lgtm
9 years, 1 month ago (2011-11-18 02:18:27 UTC) #6
awong
LGTM Thanks for taking care of this one. Quite the doozy. http://codereview.chromium.org/8555001/diff/6037/chrome_frame/chrome_frame_delegate.h File chrome_frame/chrome_frame_delegate.h (right): ...
9 years, 1 month ago (2011-11-18 02:21:10 UTC) #7
James Hawkins
http://codereview.chromium.org/8555001/diff/6037/chrome_frame/chrome_frame_delegate.h File chrome_frame/chrome_frame_delegate.h (right): http://codereview.chromium.org/8555001/diff/6037/chrome_frame/chrome_frame_delegate.h#newcode181 chrome_frame/chrome_frame_delegate.h:181: task->task.Run(); On 2011/11/18 02:21:10, awong wrote: > Being OCD...but ...
9 years, 1 month ago (2011-11-18 02:24:43 UTC) #8
robertshield
9 years, 1 month ago (2011-11-18 03:24:11 UTC) #9 
On 2011/11/18 02:24:43, James Hawkins wrote:
>
http://codereview.chromium.org/8555001/diff/6037/chrome_frame/chrome_frame_de...
> File chrome_frame/chrome_frame_delegate.h (right):
> 
>
http://codereview.chromium.org/8555001/diff/6037/chrome_frame/chrome_frame_de...
> chrome_frame/chrome_frame_delegate.h:181: task->task.Run();
> On 2011/11/18 02:21:10, awong wrote:
> > Being OCD...but can we call the local variable pending_task?
> 
> Done.

LGTM, if you need owners.

Powered by Google App Engine
This is Rietveld 408576698