Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 855453003: Update {virtual,override,final} for ui/views_content_client to follow C++11 style. (Closed)

Created:
5 years, 11 months ago by tapted
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20141229-MacViews-bringup2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} for ui/views_content_client to follow C++11 style. Fixes compile of views_examples_with_content_exe and app_list_demo on Mac with toolkit_views. BUG=417463 Committed: https://crrev.com/9cdb7b366678a0cf4abfa9fb76ac2f1395dbcc3c Cr-Commit-Position: refs/heads/master@{#311765}

Patch Set 1 #

Patch Set 2 : fix chromeos too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M ui/views_content_client/views_content_client_main_parts_chromeos.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi sky, please take a look I missed these in r311528 because the bot I ...
5 years, 11 months ago (2015-01-15 13:01:54 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-15 18:34:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855453003/20001
5 years, 11 months ago (2015-01-15 22:18:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-15 23:27:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:28:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9cdb7b366678a0cf4abfa9fb76ac2f1395dbcc3c
Cr-Commit-Position: refs/heads/master@{#311765}

Powered by Google App Engine
This is Rietveld 408576698