LayoutTests/fast/multicol/span/change-spanner-margins.html - Issue 855413002: [New Multicolumn] Support for block direction margins on spanners.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/span/change-spanner-margins.html

Issue 855413002: [New Multicolumn] Support for block direction margins on spanners. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: code review - add descriptions to tests. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/span/adjacent-spanners-with-margin-expected.html ('k') | LayoutTests/fast/multicol/span/change-spanner-margins-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>Test that changing spanner margins dynamically works.</p>

	3 <p>Below there should be a blue square with a thick black border, and no visible FAIL.</p>

	4 <div style="-webkit-columns:3; width:20em; line-height:2em; background:black;">

	5 FAIL<br>

	6 <div id="target" style="-webkit-column-span:all; height:14em; margin:-3em 0; background:blue;"></div>

	7 FAIL<br>

	8 </div>

	9 <script>

	10 onload = function() {

	11 var target = document.getElementById('target');

	12 target.style.margin = '1em 15% 5% 3em';

	13 }

	14 </script>

OLD	NEW