Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: cc/output/overlay_strategy_single_on_top.cc

Issue 855403002: cc: Change the restrictions on overlays for video (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/overlay_strategy_single_on_top.h ('k') | cc/output/overlay_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/overlay_strategy_single_on_top.h" 5 #include "cc/output/overlay_strategy_single_on_top.h"
6 6
7 #include <limits>
8
7 #include "cc/quads/draw_quad.h" 9 #include "cc/quads/draw_quad.h"
10 #include "cc/quads/solid_color_draw_quad.h"
11 #include "cc/quads/stream_video_draw_quad.h"
8 #include "cc/quads/texture_draw_quad.h" 12 #include "cc/quads/texture_draw_quad.h"
13 #include "ui/gfx/geometry/point3_f.h"
9 #include "ui/gfx/geometry/rect_conversions.h" 14 #include "ui/gfx/geometry/rect_conversions.h"
10 #include "ui/gfx/transform.h" 15 #include "ui/gfx/transform.h"
11 16
12 namespace cc { 17 namespace cc {
13 18
14 OverlayStrategySingleOnTop::OverlayStrategySingleOnTop( 19 OverlayStrategySingleOnTop::OverlayStrategySingleOnTop(
15 OverlayCandidateValidator* capability_checker, 20 OverlayCandidateValidator* capability_checker,
16 ResourceProvider* resource_provider) 21 ResourceProvider* resource_provider)
17 : capability_checker_(capability_checker), 22 : capability_checker_(capability_checker),
18 resource_provider_(resource_provider) {} 23 resource_provider_(resource_provider) {}
19 24
25 bool OverlayStrategySingleOnTop::IsOverlayQuad(const DrawQuad* draw_quad) {
26 unsigned int resource_id;
27 switch (draw_quad->material) {
28 case DrawQuad::TEXTURE_CONTENT:
29 resource_id = TextureDrawQuad::MaterialCast(draw_quad)->resource_id;
30 break;
31 case DrawQuad::STREAM_VIDEO_CONTENT:
32 resource_id = StreamVideoDrawQuad::MaterialCast(draw_quad)->resource_id;
33 break;
34 default:
35 return false;
36 }
37 return resource_provider_->AllowOverlay(resource_id);
38 }
39
40 bool OverlayStrategySingleOnTop::GetTextureQuadInfo(
41 const TextureDrawQuad& quad,
42 OverlayCandidate* quad_info) {
43 gfx::OverlayTransform overlay_transform =
44 OverlayCandidate::GetOverlayTransform(quad.quadTransform(), quad.flipped);
45 if (quad.background_color != SK_ColorTRANSPARENT ||
46 quad.premultiplied_alpha ||
47 overlay_transform == gfx::OVERLAY_TRANSFORM_INVALID)
48 return false;
49 quad_info->resource_id = quad.resource_id;
50 quad_info->transform = overlay_transform;
51 quad_info->uv_rect = BoundingRect(quad.uv_top_left, quad.uv_bottom_right);
52 return true;
53 }
54
55 bool OverlayStrategySingleOnTop::GetVideoQuadInfo(
56 const StreamVideoDrawQuad& quad,
57 OverlayCandidate* quad_info) {
58 gfx::OverlayTransform overlay_transform =
59 OverlayCandidate::GetOverlayTransform(quad.quadTransform(), false);
60 if (overlay_transform == gfx::OVERLAY_TRANSFORM_INVALID)
61 return false;
62 if (!quad.matrix.IsScaleOrTranslation()) {
63 // We cannot handle anything other than scaling & translation for texture
64 // coordinates yet.
65 return false;
66 }
67 quad_info->resource_id = quad.resource_id;
68 quad_info->transform = overlay_transform;
69
70 gfx::Point3F uv0 = gfx::Point3F(0, 0, 0);
71 gfx::Point3F uv1 = gfx::Point3F(1, 1, 0);
72 quad.matrix.TransformPoint(&uv0);
73 quad.matrix.TransformPoint(&uv1);
74 gfx::Vector3dF delta = uv1 - uv0;
75 if (delta.x() < 0) {
76 quad_info->transform = OverlayCandidate::ModifyTransform(
77 quad_info->transform, gfx::OVERLAY_TRANSFORM_FLIP_HORIZONTAL);
78 float x0 = uv0.x();
79 uv0.set_x(uv1.x());
80 uv1.set_x(x0);
81 delta.set_x(-delta.x());
82 }
83
84 if (delta.y() < 0) {
85 // In this situation, uv0y < uv1y. Since we overlay inverted, a request
86 // to invert the source texture means we can just output the texture
87 // normally and it will be correct.
88 quad_info->uv_rect = gfx::RectF(uv0.x(), uv1.y(), delta.x(), -delta.y());
89 } else {
90 quad_info->transform = OverlayCandidate::ModifyTransform(
91 quad_info->transform, gfx::OVERLAY_TRANSFORM_FLIP_VERTICAL);
92 quad_info->uv_rect = gfx::RectF(uv0.x(), uv0.y(), delta.x(), delta.y());
93 }
94 return true;
95 }
96
97 bool OverlayStrategySingleOnTop::GetCandidateQuadInfo(
98 const DrawQuad& draw_quad,
99 OverlayCandidate* quad_info) {
100 // All quad checks.
101 if (draw_quad.needs_blending || draw_quad.shared_quad_state->opacity != 1.f ||
102 draw_quad.shared_quad_state->blend_mode != SkXfermode::kSrcOver_Mode)
103 return false;
104
105 if (draw_quad.material == DrawQuad::TEXTURE_CONTENT) {
106 const TextureDrawQuad& quad = *TextureDrawQuad::MaterialCast(&draw_quad);
107 if (!GetTextureQuadInfo(quad, quad_info))
108 return false;
109 } else if (draw_quad.material == DrawQuad::STREAM_VIDEO_CONTENT) {
110 const StreamVideoDrawQuad& quad =
111 *StreamVideoDrawQuad::MaterialCast(&draw_quad);
112 if (!GetVideoQuadInfo(quad, quad_info))
113 return false;
114 }
115
116 quad_info->format = RGBA_8888;
117 quad_info->display_rect = OverlayCandidate::GetOverlayRect(
118 draw_quad.quadTransform(), draw_quad.rect);
119 return true;
120 }
121
20 bool OverlayStrategySingleOnTop::Attempt( 122 bool OverlayStrategySingleOnTop::Attempt(
21 RenderPassList* render_passes_in_draw_order, 123 RenderPassList* render_passes_in_draw_order,
22 OverlayCandidateList* candidate_list) { 124 OverlayCandidateList* candidate_list) {
23 // Only attempt to handle very simple case for now. 125 // Only attempt to handle very simple case for now.
24 if (!capability_checker_) 126 if (!capability_checker_)
25 return false; 127 return false;
26 128
27 RenderPass* root_render_pass = render_passes_in_draw_order->back(); 129 RenderPass* root_render_pass = render_passes_in_draw_order->back();
28 DCHECK(root_render_pass); 130 DCHECK(root_render_pass);
29 131
132 OverlayCandidate candidate;
30 QuadList& quad_list = root_render_pass->quad_list; 133 QuadList& quad_list = root_render_pass->quad_list;
31 auto candidate_iterator = quad_list.end(); 134 auto candidate_iterator = quad_list.end();
32 for (auto it = quad_list.begin(); it != quad_list.end(); ++it) { 135 for (auto it = quad_list.begin(); it != quad_list.end(); ++it) {
33 const DrawQuad* draw_quad = *it; 136 const DrawQuad* draw_quad = *it;
34 if (draw_quad->material == DrawQuad::TEXTURE_CONTENT) { 137 if (IsOverlayQuad(draw_quad)) {
35 const TextureDrawQuad& quad = *TextureDrawQuad::MaterialCast(draw_quad);
36 if (!resource_provider_->AllowOverlay(quad.resource_id)) {
37 continue;
38 }
39 // Check that no prior quads overlap it. 138 // Check that no prior quads overlap it.
40 bool intersects = false; 139 bool intersects = false;
41 gfx::RectF rect = draw_quad->rect; 140 gfx::RectF rect = draw_quad->rect;
42 draw_quad->quadTransform().TransformRect(&rect); 141 draw_quad->quadTransform().TransformRect(&rect);
43 for (auto overlap_iter = quad_list.cbegin(); overlap_iter != it; 142 for (auto overlap_iter = quad_list.cbegin(); overlap_iter != it;
44 ++overlap_iter) { 143 ++overlap_iter) {
45 gfx::RectF overlap_rect = overlap_iter->rect; 144 gfx::RectF overlap_rect = overlap_iter->rect;
46 overlap_iter->quadTransform().TransformRect(&overlap_rect); 145 overlap_iter->quadTransform().TransformRect(&overlap_rect);
47 if (rect.Intersects(overlap_rect)) { 146 if (rect.Intersects(overlap_rect)) {
48 intersects = true; 147 intersects = true;
49 break; 148 break;
50 } 149 }
51 } 150 }
52 if (intersects) 151 if (intersects || !GetCandidateQuadInfo(*draw_quad, &candidate))
53 continue; 152 continue;
54 candidate_iterator = it; 153 candidate_iterator = it;
55 break; 154 break;
56 } 155 }
57 } 156 }
58 if (candidate_iterator == quad_list.end()) 157 if (candidate_iterator == quad_list.end())
59 return false; 158 return false;
60 const TextureDrawQuad& quad =
61 *TextureDrawQuad::MaterialCast(*candidate_iterator);
62
63 // Simple quads only.
64 gfx::OverlayTransform overlay_transform =
65 OverlayCandidate::GetOverlayTransform(quad.quadTransform(), quad.flipped);
66 if (overlay_transform == gfx::OVERLAY_TRANSFORM_INVALID ||
67 !quad.quadTransform().IsIdentityOrTranslation() || quad.needs_blending ||
68 quad.shared_quad_state->opacity != 1.f ||
69 quad.shared_quad_state->blend_mode != SkXfermode::kSrcOver_Mode ||
70 quad.premultiplied_alpha || quad.background_color != SK_ColorTRANSPARENT)
71 return false;
72 159
73 // Add our primary surface. 160 // Add our primary surface.
74 OverlayCandidateList candidates; 161 OverlayCandidateList candidates;
75 OverlayCandidate main_image; 162 OverlayCandidate main_image;
76 main_image.display_rect = root_render_pass->output_rect; 163 main_image.display_rect = root_render_pass->output_rect;
77 main_image.format = RGBA_8888;
78 candidates.push_back(main_image); 164 candidates.push_back(main_image);
79 165
80 // Add the overlay. 166 // Add the overlay.
81 OverlayCandidate candidate;
82 candidate.transform = overlay_transform;
83 candidate.display_rect =
84 OverlayCandidate::GetOverlayRect(quad.quadTransform(), quad.rect);
85 candidate.uv_rect = BoundingRect(quad.uv_top_left, quad.uv_bottom_right);
86 candidate.format = RGBA_8888;
87 candidate.resource_id = quad.resource_id;
88 candidate.plane_z_order = 1; 167 candidate.plane_z_order = 1;
89 candidates.push_back(candidate); 168 candidates.push_back(candidate);
90 169
91 // Check for support. 170 // Check for support.
92 capability_checker_->CheckOverlaySupport(&candidates); 171 capability_checker_->CheckOverlaySupport(&candidates);
93 172
94 // If the candidate can be handled by an overlay, create a pass for it. 173 // If the candidate can be handled by an overlay, create a pass for it.
95 if (candidates[1].overlay_handled) { 174 if (candidates[1].overlay_handled) {
96 quad_list.EraseAndInvalidateAllPointers(candidate_iterator); 175 quad_list.EraseAndInvalidateAllPointers(candidate_iterator);
97 candidate_list->swap(candidates); 176 candidate_list->swap(candidates);
98 return true; 177 return true;
99 } 178 }
100 return false; 179 return false;
101 } 180 }
102 181
103 } // namespace cc 182 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/overlay_strategy_single_on_top.h ('k') | cc/output/overlay_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698