ServiceWorker: Enqueue state change events until the worker thread gets ready

content/browser/service_worker/service_worker_provider_host.h

Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 03cb0c638d04a2e688e2a9d0843d0bac1efd9da2..40c410f41ecfbba65c8f7a4a88d88249f06fab43 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -45,6 +45,7 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
     : public NON_EXPORTED_BASE(ServiceWorkerRegistration::Listener),
       public base::SupportsWeakPtr<ServiceWorkerProviderHost> {
  public:
+  typedef ServiceWorkerProviderHost self;

[falken, 2015/01/28 13:42:09]

comment: This pattern doesn't look idiomatic in Chromium codebase (outside some
Service Worker and sync file system classes :) ... is it really worth the level
of indirection... and is it even ok per style guide to have this lowercase type?
I'm not strongly opposed, just seems a bit off.

[nhiroki, 2015/01/28 14:08:30]

To wrap the line at 80 columns, I just copied it from other sites without
thinking. This seems no longer necessary, so I just removed.

   typedef base::Callback<void(bool)> FocusCallback;
 
   ServiceWorkerProviderHost(int render_process_id,
@@ -176,6 +177,9 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
       int worker_handle_id,
       blink::WebServiceWorkerState state);
 
+  // Sets the thread id and flushes queued events.
+  void SetReadyToSend(int render_thread_id);

[kinuko, 2015/01/28 07:13:11]

SetReadyToSendMessagesToRenderer ? (or ToWorker, maybe, as it's only used for
SWs)

[falken, 2015/01/28 13:42:09]

+1, it'd be nice to have a more descriptive name and summarize the gist of the
design doc in a comment here so the motivation is understood: events for the
worker are queued up until the worker thread id is known.

[nhiroki, 2015/01/28 13:43:22]

Done.

[nhiroki, 2015/01/28 14:08:30]

Updated.

+
  private:
   friend class ServiceWorkerProviderHostTest;
   friend class ServiceWorkerWriteToCacheJobTest;
@@ -198,8 +202,12 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
   void IncreaseProcessReference(const GURL& pattern);
   void DecreaseProcessReference(const GURL& pattern);
 
+  bool IsReadyToSend() const;
+  void Send(IPC::Message* message) const;
+
   int render_process_id_;
   int render_frame_id_;
+  int render_thread_id_;
   int provider_id_;
   GURL document_url_;
   GURL topmost_frame_url_;
@@ -213,6 +221,8 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
   ServiceWorkerDispatcherHost* dispatcher_host_;
   bool allow_association_;
 
+  std::vector<base::Closure> queued_events_;
+
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerProviderHost);
 };