Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: Source/core/inspector/V8AsyncCallTracker.cpp

Issue 855383002: DevTools: use async operation id instead of AsyncCallChain (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/V8AsyncCallTracker.cpp
diff --git a/Source/core/inspector/V8AsyncCallTracker.cpp b/Source/core/inspector/V8AsyncCallTracker.cpp
index 606e481d612580c261d03b901e6a4a5e5215210f..8f088db4c4d45092030ec9443b6ec631779319a7 100644
--- a/Source/core/inspector/V8AsyncCallTracker.cpp
+++ b/Source/core/inspector/V8AsyncCallTracker.cpp
@@ -114,13 +114,13 @@ void V8AsyncCallTracker::didEnqueueV8AsyncTask(ScriptState* state, const String&
{
ASSERT(state);
ASSERT(m_debuggerAgent->trackingAsyncCalls());
- RefPtrWillBeRawPtr<AsyncCallChain> callChain = m_debuggerAgent->traceAsyncOperationStarting(eventName);
- if (!callChain)
+ int operationId = m_debuggerAgent->traceAsyncOperationStarting(eventName);
+ if (!operationId)
return;
V8ContextAsyncCallChains* contextCallChains = m_contextAsyncCallChainMap.get(state);
if (!contextCallChains)
contextCallChains = m_contextAsyncCallChainMap.set(state, adoptPtrWillBeNoop(new V8ContextAsyncCallChains(m_debuggerAgent))).storedValue->value.get();
- contextCallChains->m_v8AsyncCallChains.set(makeV8AsyncTaskUniqueId(eventName, id), callChain.release());
+ contextCallChains->m_v8AsyncCallChains.set(makeV8AsyncTaskUniqueId(eventName, id), operationId);
}
void V8AsyncCallTracker::willHandleV8AsyncTask(ScriptState* state, const String& eventName, int id)
@@ -132,7 +132,7 @@ void V8AsyncCallTracker::willHandleV8AsyncTask(ScriptState* state, const String&
m_debuggerAgent->traceAsyncCallbackStarting(state->isolate(), contextCallChains->m_v8AsyncCallChains.get(taskId));
contextCallChains->m_v8AsyncCallChains.remove(taskId);
} else {
- m_debuggerAgent->traceAsyncCallbackStarting(state->isolate(), nullptr);
+ m_debuggerAgent->traceAsyncCallbackStarting(state->isolate(), InspectorDebuggerAgent::unknownAsyncOperationId);
}
}

Powered by Google App Engine
This is Rietveld 408576698