Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 855323004: Exclude a couple of tests that fail under MSan (Closed)

Created:
5 years, 11 months ago by Timur Iskhodzhanov
Modified:
5 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude a couple of tests that fail under MSan BUG=449995, 445745 NOTRY=true TBR=noel@chromium.org,raymes@chromium.org Committed: https://crrev.com/2ec7e9aea3a436752870b95c6b67bc738988e08c Cr-Commit-Position: refs/heads/master@{#312105}

Patch Set 1 #

Patch Set 2 : Replace crbug/448230 with crbug/445745 as the former was dup'ed against the latter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M chrome/browser/resources/pdf/pdf_extension_test.cc View 1 chunk +7 lines, -1 line 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 8 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Timur Iskhodzhanov
TBR
5 years, 11 months ago (2015-01-19 13:14:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855323004/20001
5 years, 11 months ago (2015-01-19 13:22:56 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-19 13:22:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855323004/20001
5 years, 11 months ago (2015-01-19 13:23:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-19 13:24:34 UTC) #9
Noel Gordon
LGTM Ramyes, you should also look post commit.
5 years, 11 months ago (2015-01-19 13:24:48 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 13:26:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ec7e9aea3a436752870b95c6b67bc738988e08c
Cr-Commit-Position: refs/heads/master@{#312105}

Powered by Google App Engine
This is Rietveld 408576698