Refactoring of code by moving navigate_() to separate file.

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 123 matching lines @@
       // We should not change zoom level when we are responsible for initiating
       // the zoom. onZoomChange() is called before setZoomComplete() callback
       // when we initiate the zoom.
       if ((zoomDelta > MIN_ZOOM_DELTA) && !this.setZoomInProgress_)
         this.viewport_.setZoom(zoomChangeInfo.newZoomFactor);
     }.bind(this));
   }
 
   // Parse open pdf parameters.
   this.paramsParser_ = new OpenPDFParamsParser();
+  this.navigatePDF_ = new NavigationPDF();

[raymes, 2015/01/20 02:58:29]

this.navigator_ = new Navigator(this.viewport_, this.paramsParser_);

[Deepak, 2015/01/20 07:08:37]

we should not pass these here as information in these parameters is not ready. 
As these parameters are required for with in the page navigation or opening link
in the same tab.So passing this info in arguments.

 }
 
 PDFViewer.prototype = {
   /**
    * @private
    * Handle key events. These may come from the user directly or via the
    * scripting API.
    * @param {KeyboardEvent} e the event to handle.
    */
   handleKeyEvent_: function(e) {
@@ skipping 186 matching lines @@
    */
   onPasswordSubmitted_: function(event) {
     this.plugin_.postMessage({
       type: 'getPasswordComplete',
       password: event.detail.password
     });
   },
 
   /**
    * @private
-   * Helper function to navigate to given URL. This might involve navigating
-   * within the PDF page or opening a new url (in the same tab or a new tab).
-   * @param {string} url The URL to navigate to.
-   * @param {boolean} newTab Whether to perform the navigation in a new tab or
-   * in the current tab.
-   */
-  navigate_: function(url, newTab) {
-    if (url.length == 0)
-      return;
-    var originalUrl = this.streamDetails_.originalUrl;
-    // If |urlFragment| starts with '#', then it's for the same URL with a
-    // different URL fragment.
-    if (url.charAt(0) == '#') {
-      // if '#' is already present in |originalUrl| then remove old fragment
-      // and add new url fragment.
-      var hashIndex = originalUrl.search('#');
-      if (hashIndex != -1)
-        url = originalUrl.substring(0, hashIndex) + url;
-      else
-        url = originalUrl + url;
-    }
-
-    var inputURL = url;
-    // If there's no scheme, add http.
-    if (inputURL.indexOf('://') == -1 && inputURL.indexOf('mailto:') == -1)
-      inputURL = 'http://' + inputURL;
-
-    // Make sure inputURL starts with a valid scheme.
-    if (inputURL.indexOf('http://') != 0 &&
-        inputURL.indexOf('https://') != 0 &&
-        inputURL.indexOf('ftp://') != 0 &&
-        inputURL.indexOf('file://') != 0 &&
-        inputURL.indexOf('mailto:') != 0) {
-      return;
-    }
-    // Make sure inputURL is not only a scheme.
-    if (inputURL == 'http://' ||
-        inputURL == 'https://' ||
-        inputURL == 'ftp://' ||
-        inputURL == 'file://' ||
-        inputURL == 'mailto:') {
-      return;
-    }
-
-    if (newTab) {
-      chrome.tabs.create({ url: inputURL });
-    } else {
-      var pageNumber =
-          this.paramsParser_.getViewportFromUrlParams(inputURL).page;
-      if (pageNumber != undefined)
-        this.viewport_.goToPage(pageNumber);
-      else
-        window.location.href = inputURL;
-    }
-  },
-
-  /**
-   * @private
    * An event handler for handling message events received from the plugin.
    * @param {MessageObject} message a message event.
    */
   handlePluginMessage_: function(message) {
     switch (message.data.type.toString()) {
       case 'documentDimensions':
         this.documentDimensions_ = message.data;
         this.viewport_.setDocumentDimensions(this.documentDimensions_);
         // If we received the document dimensions, the password was good so we
         // can dismiss the password screen.
@@ skipping 25 matching lines @@
         break;
       case 'goToPage':
         this.viewport_.goToPage(message.data.page);
         break;
       case 'loadProgress':
         this.updateProgress_(message.data.progress);
         break;
       case 'navigate':
         if (this.isPrintPreview_)
           break;
-        this.navigate_(message.data.url, message.data.newTab);
+        this.navigatePDF_.navigate(message.data.url, message.data.newTab,
+            this.streamDetails_.originalUrl);
         break;
       case 'setNamedDestinations':
         this.paramsParser_.namedDestinations = message.data.namedDestinations;
         break;
       case 'setScrollPosition':
         var position = this.viewport_.position;
         if (message.data.x !== undefined)
           position.x = message.data.x;
         if (message.data.y !== undefined)
           position.y = message.data.y;
@@ skipping 222 matching lines @@
   },
 
   /**
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;

[raymes, 2015/01/21 07:03:44]

Please keep this. It is used in tests

   }
 };