Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 855263002: Revert of Reland Auto-generate v8 version based on tags. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland Auto-generate v8 version based on tags. (patchset #1 id:1 of https://codereview.chromium.org/843913009/) Reason for revert: The gclient hook of v8 is not executed on this builder: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/49765 Original issue's description: > Reland Auto-generate v8 version based on tags. > > This relands the CL > https://codereview.chromium.org/797503007/. > > It runs the version generation two times. First during > runhooks as a fallback for recipes that loose git context > (e.g. android_aosp). Second during compilation like in the > original CL. In case of failures, the result from the > runhooks call will be reused. > > BUG=chromium:446166 > LOG=n > > Committed: https://crrev.com/d3d6e38b2cba73b52bd5ed00f4441a7db3284a19 > Cr-Commit-Position: refs/heads/master@{#26120} TBR=jochen@chromium.org,jkummerow@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:446166 Committed: https://crrev.com/12adf1474d92839bd187c4cecc89a5689159575b Cr-Commit-Position: refs/heads/master@{#26121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -138 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 4 chunks +1 line, -21 lines 0 comments Download
M DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +1 line, -35 lines 0 comments Download
M tools/push-to-trunk/generate_version.py View 3 chunks +18 lines, -74 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Achenbach
Created Revert of Reland Auto-generate v8 version based on tags.
5 years, 11 months ago (2015-01-18 15:42:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855263002/1
5 years, 11 months ago (2015-01-18 15:42:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-18 15:43:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/12adf1474d92839bd187c4cecc89a5689159575b Cr-Commit-Position: refs/heads/master@{#26121}
5 years, 11 months ago (2015-01-18 15:43:28 UTC) #4
tandrii_google
lgtm
5 years, 11 months ago (2015-01-19 10:10:00 UTC) #6
Michael Achenbach
5 years, 11 months ago (2015-01-19 10:56:26 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/861593002/ by machenbach@chromium.org.

The reason for reverting is: Next try....

Powered by Google App Engine
This is Rietveld 408576698