Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 855253003: Add util scripts for killing android webview shell. (Closed)

Created:
5 years, 11 months ago by william.xie1
Modified:
5 years, 11 months ago
Reviewers:
klundberg, jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add util scripts for killing android webview shell. BUG=None TEST= Committed: https://crrev.com/aa928ff8aa04cba903718f2bad61bce06b763343 Cr-Commit-Position: refs/heads/master@{#312305}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
A + build/android/adb_kill_android_webview_shell View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
william.xie1
PTAL
5 years, 11 months ago (2015-01-19 01:52:53 UTC) #2
william.xie1
PTAL
5 years, 11 months ago (2015-01-20 00:21:58 UTC) #5
jbudorick
lgtm w/ nit https://codereview.chromium.org/855253003/diff/1/build/android/adb_kill_android_webview_shell File build/android/adb_kill_android_webview_shell (right): https://codereview.chromium.org/855253003/diff/1/build/android/adb_kill_android_webview_shell#newcode3 build/android/adb_kill_android_webview_shell:3: # Copyright (c) 2012 The Chromium ...
5 years, 11 months ago (2015-01-20 14:18:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855253003/1
5 years, 11 months ago (2015-01-20 23:06:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855253003/20001
5 years, 11 months ago (2015-01-20 23:22:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 00:58:12 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 00:59:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa928ff8aa04cba903718f2bad61bce06b763343
Cr-Commit-Position: refs/heads/master@{#312305}

Powered by Google App Engine
This is Rietveld 408576698